Closed
Bug 1459826
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 10884 - webrtc wpt: pass test in promise_test and async_test
Categories
(Core :: WebRTC, enhancement, P4)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10884 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/w3c/web-platform-tests/pull/10884
Details from upstream follow.
Philipp Hancke <philipp.hancke@googlemail.com> wrote:
> webrtc wpt: pass test in promise_test and async_test
>
> passes the test argument in promise_test and async_test
> so it can be used to add cleanup.
> Change done with a jscodeshift codemod that detects
> there were no arguments to promise_test (or async_test):
>
> export default function transformer(file, api) {
> const j = api.jscodeshift;
> return j(file.source)
> // .find(j.CallExpression)
> .find(j.CallExpression, {callee: {type: 'Identifier', name: 'promise_test'}})
> .forEach(path => {
> if (path.value.arguments[0].params.length === 0) {
> path.value.arguments[0].params.push(j.identifier('t'));
> }
> })
> .toSource();
> };
>
> BUG=836871
>
> Change-Id: Ie7dd7fb0dd8a4da6c4c00f3616fd41d1d47854ef
>
> Reviewed-on: https://chromium-review.googlesource.com/1047674
> WPT-Export-Revision: b65b56122de3edc5a727abd38f592988b96592a8
Reporter | ||
Updated•7 years ago
|
Component: web-platform-tests → WebRTC
Product: Testing → Core
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=20bd1ab32388a45263d06b88e70c7eb8e9737107
Reporter | ||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Ran 3 tests and 15 subtests
OK : 3
FAIL : 15
Reporter | ||
Comment 5•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=352256056e9af58cabfd9e3dc04f1a017118e904
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/452db0cd518c
[wpt PR 10884] - webrtc wpt: pass test in promise_test and async_test, a=testonly
![]() |
||
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•