1459844 - Share more code and fix inconsistencies between HTMLStyleElement / SVGStyleElement.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1459498.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1459844: Share more code and fix some inconsistencies between html / svg style elements.

Review commit: https://reviewboard.mozilla.org/r/242276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242276/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8973942 [details]
Bug 1459844: Share more code and fix some inconsistencies between html / svg style elements.

https://reviewboard.mozilla.org/r/242276/#review248400

::: dom/base/nsStyleLinkElement.h:101
(Diff revision 1)
> +  // Gets a suitable title and media for SheetInfo out of an element, which
> +  // needs to be `this`.
> +  //
> +  // NOTE(emilio): Needs nsString instead of nsAString because of
> +  // CompressWhitespace.
> +  void GetTitleAndMediaForElement(const mozilla::dom::Element& aSelf,

This can be static.

::: dom/base/nsStyleLinkElement.h:105
(Diff revision 1)
> +  // Returns whether the type attribute specifies the text/css mime type.
> +  bool IsCssMimeTypeAttribute(const mozilla::dom::Element& aSelf) const;

This too.

Nit: "CSS" rather than "Css", for Gecko C++ code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce2b7039f0cc
Share more code and fix some inconsistencies between html / svg style elements. r=heycam

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ce2b7039f0cc