1459902 - 9.17 - 14.71% build times (windows2012-32, windows2012-64) regression on push 827deadecf7e43ad9f9891444637be01619a2ba8 (Tue May 8 2018)

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=827deadecf7e43ad9f9891444637be01619a2ba8

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

 15%  build times windows2012-32 debug static-analysis taskcluster-c4.4xlarge     2,201.52 -> 2,525.28
  9%  build times windows2012-64 debug static-analysis taskcluster-c4.4xlarge     2,446.32 -> 2,670.69


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=13117

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ryan VanderMeulen [:RyanVM]]

We added a new static analysis check, and it unsurprisingly made those jobs run longer as a result. I don't think there's anything to do here.

Comment 2

[Andi [:andi]]

As per what Ryan said, we added a new checker that tries to mach a strict type of CallExpr, this justifies the regression. What is strange here is that it's only on Windows. I don't think we should worry here.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Isn't the check Windows-only?

Comment 4

[Andi [:andi]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Isn't the check Windows-only?

Oups, you're right, this explains why!