1459948 - Don't include super long data URIs in Highlights

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect, P3)

Description

[Tim Nguyen :ntim]

STR:
- Have highlights disabled
- Visit a super long data URI
- Enable Highlights
- Open the new tab page

AR:
- Firefox freezes
- The super long data URI appears on the new tab page

ER:
- Highlights should be smart and ignore the super long URL for performance concerns

Comment 1

[Tim Nguyen :ntim]

Attachment: long-data-uri.txt

Here's the data URI (was too large to put in a comment).

Comment 2

[Tim Spurway [:tspurway]]

Setting this as a P3 and fix-optional for this release unless there are strong objections.  Thoughts :ntim

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Another way to trigger this is to execute the following in the developer toolbar:

>> screenshot --fullpage


That pretty much makes the newtab page unusable for me until I clear my downloads.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Screen Shot 2018-05-17 at 11.55.39 AM.png

Highlights after a screenshot from Developer Toolbar.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Not a common case, but when it happens, it apparently makes the new tab unusable. To fix it or could just not show data: URIs at all, or establish a length limit to crop

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

The UI issue in Comment 4 was fixed by Bug 1464349.

Comment 7

[Alex Thayer [:alexical] (she/her)]

I don't think this is relevant with the current about:newtab anymore. Please feel free to reopen if this still applies in some way that I have overlooked.