1459985 - `./mach run -P` without a profile name is broken

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Brian Grinstead [:bgrins]]

This was due to the way <stringbundle> gets loaded as of Bug 1459245. The Custom Element doesn't get registered until MainProcessSingleton loads, but the profile manager starts before that.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1459985 - Include stringbundle Custom Element registration inside profile manager;

Currently stringbundle.js is loaded in response to the document-element-inserted message
in MainProcessSingleton. But since the profile manager loads before that script is run,
we don't register the Custom Element. This fixes that by explicitly including the script.

Review commit: https://reviewboard.mozilla.org/r/242394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242394/

Comment 2

[Brian Grinstead [:bgrins]]

Is there a technical reason we don't have tests for this? I assume with the special way it gets started (https://bugzilla.mozilla.org/show_bug.cgi?id=1459245#c20) it wouldn't be possible to write a browser-chrome test, but maybe we could add some other style of test to at least avoid a bustage? I can spin off a follow-up if you think it makes sense.

Comment 3

[Dave Townsend [:mossop]]

Having tests for profile selection and the UI is something I dream of. The only test harness we have where it /might/ work is marionette, but even then I think since we don't start up the bulk of xpcom it might not work even there. It's been on a list to look at at some point.

Comment 4

[Jorg K (CEST = GMT+2)]

If you wrote a test for that, you'd also notice that the profile manager leaks like a sieve :-( - Bug 1303637.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8974093 [details]
Bug 1459985 - Include stringbundle Custom Element registration inside profile manager;

https://reviewboard.mozilla.org/r/242394/#review248318

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecbcf736a436
Include stringbundle Custom Element registration inside profile manager;r=mossop

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ecbcf736a436