1460028 - java.lang.NullPointerException at org.mozilla.gecko.tests.SessionTest.createTestSession(SessionTest.java:141)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Jan Henning [:JanH]]

(In reply to Geoff Brown [:gbrown] from comment #351)
> I can't look into this in depth.
> 
> Usually this failure message indicates a crash during a robocop test. I
> expect there are multiple crash causes collected here.
> 
> 
> Many of the failure logs show the same NullPointerException:
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=176411209&repo=mozilla-
> inbound&lineNumber=2324
> https://treeherder.mozilla.org/logviewer.html#?job_id=176420801&repo=mozilla-
> inbound&lineNumber=1756
> https://treeherder.mozilla.org/logviewer.html#?job_id=176452085&repo=mozilla-
> inbound&lineNumber=1654
> https://treeherder.mozilla.org/logviewer.html#?job_id=176455960&repo=mozilla-
> inbound&lineNumber=1665
> 
> [task 2018-05-01T16:00:53.285Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): java.lang.NullPointerException
> [task 2018-05-01T16:00:53.286Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> org.mozilla.gecko.tests.SessionTest.createTestSession(SessionTest.java:141)
> [task 2018-05-01T16:00:53.287Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> org.mozilla.gecko.tests.AssistIntentTest.setActivityIntent(AssistIntentTest.
> java:12)
> [task 2018-05-01T16:00:53.287Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> org.mozilla.gecko.tests.BaseRobocopTest.setUp(BaseRobocopTest.java:172)
> [task 2018-05-01T16:00:53.287Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at org.mozilla.gecko.tests.UITest.setUp(UITest.java:46)
> [task 2018-05-01T16:00:53.287Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at junit.framework.TestCase.runBare(TestCase.java:132)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> junit.framework.TestResult$1.protect(TestResult.java:115)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> junit.framework.TestResult.runProtected(TestResult.java:133)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at junit.framework.TestResult.run(TestResult.java:118)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at junit.framework.TestCase.run(TestCase.java:124)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
> [task 2018-05-01T16:00:53.288Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
> [task 2018-05-01T16:00:53.289Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.
> java:554)
> [task 2018-05-01T16:00:53.289Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> org.mozilla.gecko.FennecInstrumentationTestRunner.
> onStart(FennecInstrumentationTestRunner.java:64)
> [task 2018-05-01T16:00:53.289Z] 16:00:53     INFO -  05-01 09:00:30.402
> I/TestRunner( 1803): 	at
> android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:
> 1701)
> 
> :JanH -- It looks like you have worked on SessionTest in the past; could you
> have a look?

(In reply to Jan Henning [:JanH] from comment #352)
> Hmm, the top line there is SessionTest.java:141, which is "PageInfo home =
> new PageInfo(StringHelper.STATIC_ABOUT_HOME_URL);" [1], where
> STATIC_ABOUT_HOME_URL is a static string and the PageInfo constructor
> doesn't do anything terribly complicated and in any case doesn't even appear
> in the stack trace.
> 
> So as a first approximation I've got no idea why and how we're encountering
> a null pointer exception here.
> The only idea I've got is experimentally replacing the StringHelper
> reference with a string literal in case it's some very weird class
> initialisation issue, but other than that I'm at a loss here.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1460028 - Experimental - Use string literal instead of static variable in SessionTest.

Experimentally try using a String literal in case the NullPointerException at
that line is caused by some weird class initialisation issue.

Review commit: https://reviewboard.mozilla.org/r/242432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242432/

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8974139 [details]
Bug 1460028 - Experimental - Use string literal instead of static variable in SessionTest.

https://reviewboard.mozilla.org/r/242432/#review248352

Thanks. I don't have a better idea!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fd5996b2d80
Experimental - Use string literal instead of static variable in SessionTest. r=gbrown

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0fd5996b2d80

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.