Closed Bug 1460192 Opened 2 years ago Closed 2 years ago

Rename pointing struct to inherited_ui

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

The style struct Pointing in Servo corresponds to Gecko's UserInterface, and it contains more than just pointing properties, so it makes more sense to be called inherited_ui instead.
Comment on attachment 8974261 [details]
Bug 1460192 - Rename pointing to inherited_ui.

https://reviewboard.mozilla.org/r/242580/#review248422

::: servo/components/style/properties/gecko.mako.rs:5329
(Diff revision 1)
> -            // We don't need to record this struct as uncacheable, like when setting
> -            // background-image to a url() value, since only properties in reset structs
> -            // are re-used from the applicable declaration cache, and the Pointing struct
> -            // is an inherited struct.
> +            // We don't need to record this struct as uncacheable, like when
> +            // setting background-image to a url() value, since only properties
> +            // in reset structs are re-used from the applicable declaration
> +            // cache, and the InheritedUI struct is an inherited struct.

This comment (and the other similar one in set_list_style_image) can be removed since we no longer have this problem of being unable to cache image values since https://github.com/servo/servo/pull/17788.
Attachment #8974261 - Flags: review?(cam) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b07beb747fd
Rename pointing to inherited_ui. r=heycam
https://hg.mozilla.org/mozilla-central/rev/7b07beb747fd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.