1460192 - Rename pointing struct to inherited_ui

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

The style struct Pointing in Servo corresponds to Gecko's UserInterface, and it contains more than just pointing properties, so it makes more sense to be called inherited_ui instead.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1460192 - Rename pointing to inherited_ui.

And also merge values::*::pointing into values::*::ui.

Review commit: https://reviewboard.mozilla.org/r/242580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242580/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8974261 [details]
Bug 1460192 - Rename pointing to inherited_ui.

https://reviewboard.mozilla.org/r/242580/#review248422

::: servo/components/style/properties/gecko.mako.rs:5329
(Diff revision 1)
> -            // We don't need to record this struct as uncacheable, like when setting
> -            // background-image to a url() value, since only properties in reset structs
> -            // are re-used from the applicable declaration cache, and the Pointing struct
> -            // is an inherited struct.
> +            // We don't need to record this struct as uncacheable, like when
> +            // setting background-image to a url() value, since only properties
> +            // in reset structs are re-used from the applicable declaration
> +            // cache, and the InheritedUI struct is an inherited struct.

This comment (and the other similar one in set_list_style_image) can be removed since we no longer have this problem of being unable to cache image values since https://github.com/servo/servo/pull/17788.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8974261 [details]
Bug 1460192 - Rename pointing to inherited_ui.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242580/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b07beb747fd
Rename pointing to inherited_ui. r=heycam

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7b07beb747fd