1460206 - Enable Chrome fling physics on Android by default (and ride the trains)

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

Bug 1459293 enabled the Chrome fling physics for Nightly only. Once we fix outstanding issues like bug 1457586 and bug 1458653, we can enable the apz.android.chrome_fling_physics.enabled pref by default and let it ride the trains.

The GeckoView team would like the new fling physics to ride the trains with 62.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

To ride 62 we have about 5 weeks. Botond do you think this is doable?

Comment 2

[Botond Ballo [:botond]]

(In reply to David Bolter [:davidb] (NeedInfo me for attention) from comment #1)
> To ride 62 we have about 5 weeks. Botond do you think this is doable?

Based on the analysis in bug 1457586 comment 5, that bug will not be a trivial fix. Given the sophistication of Chrome's velocity tracking code, we're looking at a porting effort comparable to bug 1448439.

Bug 1458653 is still an unknown. It may just be fixed by the changes in bug 1457586, or it may require a separate investigation and fix.

I'm happy to make this my priority after swimming out from under important regressions like bug 1459890 and bug 1459696, but given the timeline and the fact that mentoring the intern project will also take up some my bandwidth, I'm hesitant to make any guarantees.

Comment 3

[Chris Peterson [:cpeterson]]

Kevin, having tried the new scrolling behavior, do you think it (without fixes for bug 1458653 or bug 1457586) is a better user experience than Fennec's current scrolling behavior?

We don't have to wait for a perfect solution if we can give users something better (in 62) than what they currently have.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Just a NI'ing Stephen so that he is aware of the work here.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

It is different. Feels slippier in small flings. Not sure that any of the current raised issues are blockers at least for beta. My only concern is that if we don't do this work now it will be a long time before we have cycles to look at this again.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

During triage we felt this was P1 and at the same time realize there are dependencies.

Comment 7

[Botond Ballo [:botond]]

Having discussed this with Chris and others, there seems to be agreement that the new fling physics is an improvement over the old one even without the dependencies of this bug being fixed. So, I'm going to post a patch to let the new physics ride the trains for 62.

I still plan to work on the dependencies, it's just looking uncertain if they'll make 62.

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1460206 - Let the new Android fling physics ride the trains.

Review commit: https://reviewboard.mozilla.org/r/248634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248634/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8982734 [details]
Bug 1460206 - Let the new Android fling physics ride the trains.

https://reviewboard.mozilla.org/r/248634/#review254890

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98956646c3aa
Let the new Android fling physics ride the trains. r=kats

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/98956646c3aa

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Fennec 62 release notes.