1460228 - Move NetworkEventActor to its own module

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

devtools/server/actors/webconsole.js is very big and contains NetworkEventActor which could be pulled of in its own module.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1460228 - Move NetworkEventActor to its own module.

Review commit: https://reviewboard.mozilla.org/r/242638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242638/

Comment 2

[Alexandre Poirot [:ochameau]]

It isn't clear why, but it may speed up "custom.jsdebugger.open":
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=6ca283f776f569d6f5e4a1805d8154e87f55f3af&newProject=try&newRevision=1983e2e0f693ec67d3fd921f75dfcbd21237fa40&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1

Green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1983e2e0f693ec67d3fd921f75dfcbd21237fa40&selectedJob=177646613

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8974318 [details]
Bug 1460228 - Move NetworkEventActor to its own module.

https://reviewboard.mozilla.org/r/242638/#review250092

Seems like a good cleanup! :) Curious that it helps perf as well...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ff6f58c296
Move NetworkEventActor to its own module. r=jryans

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a9ff6f58c296