Fetch: content-length header is being added to the safe-list
Categories
(Core :: DOM: Networking, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: shacharz, Assigned: fli+bugzilla)
References
(Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete, Whiteboard: [necko-triaged], [wptsync upstream])
Attachments
(2 files)
Updated•7 years ago
|
Updated•7 years ago
|
Updated•6 years ago
|
Who would be the most suitable person to review the changes? This is my first time here, so I'm not familiar with the process of requesting a reviewer.
Comment 5•5 years ago
|
||
Hey Forrest (and Shachar), apologies for the lack of follow-up here. Junior can most likely take a look at your patch.
Comment 6•5 years ago
|
||
Hello Forrest, do you want to continue the process?
I can do the review. Just set the reviewer to JuniorHsu in phabricator.
Sorry for the extended delay. I'm pretty sure I accidentally deleted the notification emails a while back when mass-deleting old emails, and I'm just revisiting this.
Yes, I'm interested in moving forward with this patch. However, it appears that Junior's account is disabled in Phabricator. Is there anyone else I can set as the reviewer?
Updated•5 years ago
|
Comment 8•5 years ago
|
||
I think Andrea [baku] might be able to review this based on some blame info for InternalHeaders.cpp. I added them as a reviewer.
Updated•5 years ago
|
Hi all, what's the status on this issue? Is this content-length now added as a safelisted header now?
Comment 10•5 years ago
|
||
ehsueh, thanks for the reminder. Valentin, can you ensure https://phabricator.services.mozilla.com/D58492 lands? Looks like all is in order there.
Updated•5 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment 13•4 years ago
|
||
Backed out for causing failures cors-filtering.sub.any.worker.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/55cf2cda9a1002e345e5f5821701fb314fa2aab1
Failure log: https://treeherder.mozilla.org/logviewer?job_id=328841702&repo=autoland&lineNumber=2485
Comment 14•4 years ago
•
|
||
It seems you just need to remove this file:
https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/testing/web-platform/meta/fetch/api/cors/cors-filtering.sub.any.js.ini
Assignee | ||
Comment 16•4 years ago
|
||
I've updated that test-case to expect passing results.
Depends on D58492
Comment 18•4 years ago
|
||
Assignee | ||
Comment 19•4 years ago
|
||
Oh thanks! I pushed the change and didn't notice that it was already closed after you made the change. You can ignore the recent change on phabricator.
Comment 20•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4615f67be1a8
https://hg.mozilla.org/mozilla-central/rev/3b0711521076
Comment 22•4 years ago
|
||
FF87 docs for this are being done as part of https://github.com/mdn/content/pull/2766. Still waiting on discussion on BCD. Note also a little scope creep in docs for this one because I found the existing descriptions for the CORS response header safelist a bit confusing.
Comment 23•4 years ago
|
||
Setting this one to DDC; the BCD work is very nearly there.
Description
•