Closed Bug 1460357 Opened 3 years ago Closed 3 years ago

Disable AVX-Optimized Skia Code for MinGW Build

Categories

(Core :: Graphics, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

As described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85525 - gcc with MinGW will generated unaligned instructions, resulting in a crash.  We can bypass this by just disabling this code for MinGW.
Comment on attachment 8974500 [details]
Bug 1460357 Do not use optimized AVX for Skia convolve_vertically in MinGW

https://reviewboard.mozilla.org/r/242824/#review249098
Attachment #8974500 - Flags: review?(lsalzman) → review+
Comment on attachment 8974500 [details]
Bug 1460357 Do not use optimized AVX for Skia convolve_vertically in MinGW

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8974500 - Flags: approval-mozilla-esr60?
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/476091dbf8c0
Do not use optimized AVX for Skia convolve_vertically in MinGW r=lsalzman
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/476091dbf8c0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8974500 [details]
Bug 1460357 Do not use optimized AVX for Skia convolve_vertically in MinGW

mingw build fix, approved for 60.1esr
Attachment #8974500 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.