1460371 - Update Debugger Frontend v51

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

http://github.com/devtools-html/debugger.html/compare/release-50...release-51

Comment 1

[Jason Laster [:jlast]]

Attachment: rel-51-1.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5b548fcca407f4d9d3f935d1813be53dd737840

Comment 3

[Jason Laster [:jlast]]

Attachment: rel-51-2.patch

Comment 4

[Julian Descottes [:jdescottes]]

Waiting for a greener try to review. 

An overall comment is that if we could have file moves rather than delete/add, this would make the diff much easier to read. Not sure what you need to do from git-cinnabar to achieve that though.

Comment 5

[Jason Laster [:jlast]]

Attachment: rel-51-3.patch

Comment 6

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cedc6e9f42ba67c1944dec71614b04fd77f4be49

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8974694 [details] [diff] [review]
rel-51-3.patch

Review of attachment 8974694 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

As discussed: need to update the path in browser_parsable_css.
I would honestly feel better if we didn't land the src/test folder to avoid polluting the repo.
At the very least remove the 'test' entry from the DIRS in src/moz.build . Up to you.

Follow ups for next release:
- stop copying tests to src/test
- check what should be done about vendors.css

Comment 8

[Jason Laster [:jlast]]

Attachment: rel-51-4.patch

Comment 9

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4449f93930817877a0dc975e8370378c7cc7737

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b54faaaa591c
Update Debugger Frontend v51 r=jdescottes

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b54faaaa591c