1460447 - replace tree_get with glom in signature generation code

Status: RESOLVED FIXED

(Socorro :: Processor, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In bug #1383113, I ended up writing the beginnings of a tree manipulation library in socorro.lib.treelib. It had a tree_get function which let you access a specific thing in a deeply nested Python data structure where the branches may not exist.

I think glom (https://glom.readthedocs.io/en/latest/) is more flexible and a good replacement for that nascent tree manipulation library. Replacing our tree_get() calls with glom() calls will let us dump some code we are maintaining and also let us do some other things we can't currently do.

This bug covers adding glom as a dependency, removing socorro/lib/treelib.py and its tests in socorro/unittest/lib/test_treelib.py, and replacing uses of tree_get with glom.

Comment 1

[Videet Singhai]

can I take this bug?

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Videet: Do you have a local development environment set up? If not, read through:

https://socorro.readthedocs.io/en/latest/gettingstarted.html

to get one working. You'll need a local development environment working in order to work on Socorro changes.

Comment 3

[Issei Horie [:is2ei]]

Hi Will,

Could I work on this issue?

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I actually just did this in relation to some other work I was doing. Sorry about that!

I'll grab it, extract my changes, and push them now.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4496: fix bug 1460447: switch to glom

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/4547e422ec566829a98a59c598ecdf439fbc06de
fix bug 1460447: switch to glom

This drops our homegrown treelib for glom for manipulating complex Python
data structures.

https://github.com/mozilla-services/socorro/commit/960beb851940fce482f3f43ecd20a0562ebaebb8
Merge pull request #4496 from willkg/1460447-glom

fix bug 1460447: switch to glom

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4502: bug 1460447: fix errant glom call

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/840f57cfe736c5bc1a759927a8af26a4903b69ae
bug 1460447: fix errant glom call

This fixes a bug created when I switched the code from tree_get to
glom. glom requires the default to be a keyword argument.

https://github.com/mozilla-services/socorro/commit/472632aa57009165422df633940536ca6ddbf8e1
Merge pull request #4502 from willkg/1460447-fix-glom

bug 1460447: fix errant glom call