1460509 - Methods of TextEditRules and HTMLEditRules which changes DOM tree should return new error code which means editor is destroyed

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is a part of bug 1454900.

Starting from bug 1457083's fix, TextEditRules and HTMLEditRules should stop handling edit action when editor is destroyed or something when they change the DOM tree. For making follow up of bug 1457083 faster, let's fix bug 1454900 only in TextEditRules and HTMLEditRules first.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfa77416d52d9ffc469fd41b636a6e388260316e

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9056b3e8b9c14063928304e48957335516a93c03

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5dd9c1dd25f291a8811e44e7d1b28076e91936a

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3386451f1aa0cb8b4028c609a6eab2d0be8619a5

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae6665da1850bdadeb22cddc985558fe57e33236

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38c3b1d93e248be537052ae8fca71f7fa6329f07

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b54408aa5a406b71569a70baaf4aac5faa7ded26

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfd0920eadb3ef4b7ab65c7d69846b008c740c0e

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34648679ca373749f02d68d4c853320ff1810ef0

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d27d52cb6b21e6f43f267ec4eda4d77c50ebe76

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a58fe92e6b29ba2dbfaadaa7d46dc6518d65bf13

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e0ccb4d12edaa4d26e8c97ca906fce4d9f0f482

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bae692085be16b7f2b17ca388dbba81162bf9e0

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77ef284c3ce4b25a78b671a16b67e78d89986446

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b7d11e78e872a39a9d7adfbc57217048fe39721

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment

This patch defines NS_ERROR_EDITOR_DESTROYED error code as an editor module
specific error code.

And creates TextEditRules::CanHandleEditAction() to check if the instance
can keep handling edit action.

Review commit: https://reviewboard.mozilla.org/r/244916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244916/

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result

First, this patch changes TextEditRules::CreateBRInternal() to a private method
for making any callers use CreateBR() or CreateMozBR() instead.

Then, this patch makes TextEditRules::CreateBRInternal() return both nsresult
and created <br> element with CreateElementResult class.

Finally, this patch makes all callers of them check if they don't return an
error code including NS_ERROR_EDITOR_DESTROYED.

Review commit: https://reviewboard.mozilla.org/r/244918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244918/

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor

And also this patch marks it as MOZ_MUST_USE.  All callers have to check if
the result is NS_ERROR_EDITOR_DESTROYED at least.

Review commit: https://reviewboard.mozilla.org/r/244920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244920/

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Note that HTMLEditRules::DocumentModifiedWorker() is a runnable method.
So, it cannot return nsresult.  Therefore, it just checks the result
only with NS_WARNING_ASSERTION().

Review commit: https://reviewboard.mozilla.org/r/244922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244922/

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244924/

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244926/

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And also this patch removes unnecessary arguments from the method.

Review commit: https://reviewboard.mozilla.org/r/244928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244928/

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

This patch creates internal method for it as DeleteSelectionWithTransaction()
because it needs to create SelectionBatcher and destruction of it may cause
destroying the editor.  Therefore, unfortunately, all callers of
DeleteSelectionWithTransaction() needs to check CanHandleEditAction()
manually.  If we could use try-catch, we could make it safer, though.

Review commit: https://reviewboard.mozilla.org/r/244930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244930/

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244932/

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244934/

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244936/

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244938/

Comment 28

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

This patch also makes aCancel of TextEditRules::WillInsert() optional since
a lot of callers need to ignore the result.

Review commit: https://reviewboard.mozilla.org/r/244940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244940/

Comment 29

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244942/

Comment 30

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244944/

Comment 31

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 16: Make HTMLEditRules::DidAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244946/

Comment 32

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor

Review commit: https://reviewboard.mozilla.org/r/244948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244948/

Comment 33

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 18: Make HTMLEditRules::ChangeIndentation() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Additionally, this patch renames it to ChangeMarginStart() for making its
job clearer and add two inline wrapper methods.

Review commit: https://reviewboard.mozilla.org/r/244950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244950/

Comment 34

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 19: Make HTMLEditRules::AlignBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Additionally, this patch renames its specific enum class from ContentsOnly
to ResetAlignOf for making its target clearer.

Review commit: https://reviewboard.mozilla.org/r/244952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244952/

Comment 35

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 20: Make HTMLEditRules::MakeSureElemStartsAndEndsOnCR() and HTMLEditRules::MakeSureElemStartsOrEndsOnCR() return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244954/

Comment 36

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 21: Make HTMLEditRules::RemoveAlignment() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244956/

Comment 37

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 22: Mark HTMLEditRules::InsertBRIfNeededInternal() and its wrappers as MOZ_MUST_USE

Review commit: https://reviewboard.mozilla.org/r/244958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244958/

Comment 38

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 23: Make HTMLEditRules::RemoveListStructure() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244960/

Comment 39

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 24: Make HTMLEditRules::PopListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244962/

Comment 40

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 25: Make HTMLEditRules::RemoveEmptyNodes() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And this patch renames it to RemoveEmptyNodesInChangedRange().

Review commit: https://reviewboard.mozilla.org/r/244964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244964/

Comment 41

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 26: Make HTMLEditRules::AdjustSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244966/

Comment 42

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244968/

Comment 43

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244970/

Comment 44

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And this patch renames it to
InsertBRElementToEmptyListItemsAndTableCellsInChangedRange().

Review commit: https://reviewboard.mozilla.org/r/244972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244972/

Comment 45

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244974/

Comment 46

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244976/

Comment 47

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case

Review commit: https://reviewboard.mozilla.org/r/244978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244978/

Comment 48

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Unfortunately, we need to make it take out argument for returning new first
child point of right node.  If we can create JoinNodesResult which have
nsresult and EditorDOMPoint, we can avoid that, but EditorBase::JoinNodes()
does not want it.  So, even if we create such class, only 2 callers of the
methods are its users...

Review commit: https://reviewboard.mozilla.org/r/244980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244980/

Comment 49

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244982/

Comment 50

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244984/

Comment 51

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244986/

Comment 52

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244988/

Comment 53

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244990/

Comment 54

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244992/

Comment 55

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244994/

Comment 56

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244996/

Comment 57

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/244998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244998/

Comment 58

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245000/

Comment 59

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Despite of the name of GetNodesForOperation() and related methods, it changes
the DOM tree if their aTouchContent is TouchContent::yes (by default).
Therefore, they should return NS_ERROR_EDITOR_DESTROYED if they cause destroying
the editor and all callers should check the result.  Therefore, this patch mark
them as MOZ_MUST_USE.

Additionally, because of importance of aTouchContent, this patch makes the
arguments not optional.  This change must make other developers being careful
to use them.  (Although TouchContent does not feel dangerous.  We should rename
it to make its risk clearer.)

On the other hand, this patch removes aTouchContent from
GetParagraphFormatNodes() since it's always called with TouchContent::no.
Therefore, this method is always safe.

Although I tried to document those methods, but I have not understood them
completely yet.  Perhaps, we should redesign them in another bug both to
learn them and making them faster and simpler.

Review commit: https://reviewboard.mozilla.org/r/245002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245002/

Comment 60

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection

PromoteRange() related methods do not change Selection nor the DOM tree.
Therefore, they must be safe.  However, only PromoteRange() takes an nsRange
instance and modifies it.  If it's in Selection, that causes selectionchange
event.  Therefore, we should check if given range is in Selection with
MOZ_ASSERT().

Review commit: https://reviewboard.mozilla.org/r/245004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245004/

Comment 61

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245006/

Comment 62

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245008/

Comment 63

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Additionally, this patch renames it to MaybeDeleteTopMostEmptyAncestor() for
making its name explain what it does.

Review commit: https://reviewboard.mozilla.org/r/245010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245010/

Comment 64

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 49: Make HTMLEditRules::SplitMailCites() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245012/

Comment 65

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245014/

Comment 66

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 51: Make HTMLEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245016/

Comment 67

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 52: Make HTMLEditRules::LoadHTML() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245018/

Comment 68

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 53: Make HTMLEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245020/

Comment 69

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 54: Make HTMLEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245022/

Comment 70

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 55: Make HTMLEditRules::AfterEditInner() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245024/

Comment 71

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245026/

Comment 72

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245028/

Comment 73

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245030/

Comment 74

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245032/

Comment 75

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245034/

Comment 76

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And this patch renames it to SplitRangeOffFromBlock() for making the name
explain what it does since "split" is used as splitting to two nodes widely
in editor.

Review commit: https://reviewboard.mozilla.org/r/245036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245036/

Comment 77

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245038/

Comment 78

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And this patch renames it to SplitRangeOffFromBlockAndRemoveMiddleContainer()
for making the name explain what it does.

Review commit: https://reviewboard.mozilla.org/r/245040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245040/

Comment 79

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

And this patch creates a new method, OutdentAroundSelection(), to check if
restoring Selection with AutoSelectionRestorer causes destroying the editor.
However, this does NOT change any logic in the new method except changing some
else-if blocks to if blocks with early-return style.

Review commit: https://reviewboard.mozilla.org/r/245042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245042/

Comment 80

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245044/

Comment 81

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245046/

Comment 82

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review commit: https://reviewboard.mozilla.org/r/245048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245048/

Comment 83

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review commit: https://reviewboard.mozilla.org/r/245050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245050/

Comment 84

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245052/

Comment 85

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review commit: https://reviewboard.mozilla.org/r/245054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245054/

Comment 86

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review commit: https://reviewboard.mozilla.org/r/245056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245056/

Comment 87

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Additionally, it creates AutoSelectionRestorer.  So, this patch adds
CanHandleEditAction() check after its caller since even if it returns
NS_OK, the editor might have been gone.

Review commit: https://reviewboard.mozilla.org/r/245058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245058/

Comment 88

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245060/

Comment 89

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245062/

Comment 90

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245064/

Comment 91

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 76: Mark HTMLEditRules::MoveContents() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review commit: https://reviewboard.mozilla.org/r/245066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245066/

Comment 92

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 77: Make HTMLEditRules::MoveNodeSmart() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245068/

Comment 93

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 78: Make HTMLEditRules::MoveBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245070/

Comment 94

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 79: Make HTMLEditRules::TryToJoinBlocksWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245072/

Comment 95

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 80: Make HTMLEditRules::DeleteNodeIfCollapsedText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245074/

Comment 96

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 81: Make HTMLEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245076/

Comment 97

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 82: Refine comments of TextEditRules.h and HTMLEditRules.h

This patch adds new rules of TextEditRules and HTMLEditRules about
NS_ERROR_EDITOR_DESTROYED.

Additionally, this patch moves some method explanation in each .cpp file to .h
file.

Review commit: https://reviewboard.mozilla.org/r/245078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245078/

Comment 98

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 83: Make HTMLEditRules::InsertBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review commit: https://reviewboard.mozilla.org/r/245080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245080/

Comment 99

[Makoto Kato [:m_kato]]

Comment on attachment 8976830 [details]
Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment

https://reviewboard.mozilla.org/r/244916/#review251324

Comment 100

[Makoto Kato [:m_kato]]

Comment on attachment 8976831 [details]
Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result

https://reviewboard.mozilla.org/r/244918/#review251334

Comment 101

[Makoto Kato [:m_kato]]

Comment on attachment 8976832 [details]
Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor

https://reviewboard.mozilla.org/r/244920/#review251346

Comment 102

[Makoto Kato [:m_kato]]

Comment on attachment 8976833 [details]
Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244922/#review251632

Comment 103

[Makoto Kato [:m_kato]]

Comment on attachment 8976834 [details]
Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244924/#review251634

Comment 104

[Makoto Kato [:m_kato]]

Comment on attachment 8976835 [details]
Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244926/#review251636

Comment 105

[Makoto Kato [:m_kato]]

Comment on attachment 8976836 [details]
Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244928/#review251638

Comment 106

[Makoto Kato [:m_kato]]

Comment on attachment 8976837 [details]
Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244930/#review251640

Comment 107

[Makoto Kato [:m_kato]]

Comment on attachment 8976838 [details]
Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244932/#review251642

Comment 108

[Makoto Kato [:m_kato]]

Comment on attachment 8976839 [details]
Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244934/#review251670

Comment 109

[Makoto Kato [:m_kato]]

Comment on attachment 8976840 [details]
Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244936/#review251672

Comment 110

[Makoto Kato [:m_kato]]

Comment on attachment 8976841 [details]
Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244938/#review251674

Comment 111

[Makoto Kato [:m_kato]]

Comment on attachment 8976842 [details]
Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244940/#review251676

Comment 112

[Makoto Kato [:m_kato]]

Comment on attachment 8976843 [details]
Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244942/#review251678

Comment 113

[Makoto Kato [:m_kato]]

Comment on attachment 8976844 [details]
Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244944/#review251682

Comment 114

[Makoto Kato [:m_kato]]

Comment on attachment 8976845 [details]
Bug 1460509 - part 16: Make HTMLEditRules::DidAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244946/#review251686

Comment 115

[Makoto Kato [:m_kato]]

Comment on attachment 8976846 [details]
Bug 1460509 - part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor

https://reviewboard.mozilla.org/r/244948/#review251708

::: editor/libeditor/HTMLEditRules.cpp:10062
(Diff revision 1)
> -    SelectionRef().Collapse(RawRangeBoundary(positionedDiv, 0), error);
>      // Don't restore the selection
>      selectionRestorer.Abort();
> +    ErrorResult error;
> +    SelectionRef().Collapse(RawRangeBoundary(positionedDiv, 0), error);
> +    if (NS_WARN_IF(!CanHandleEditAction())) {

Need error.SuppressException() when you check destroyed at first.  If error.Failed() is true, it causes assertion.

Comment 116

[Makoto Kato [:m_kato]]

Comment on attachment 8976847 [details]
Bug 1460509 - part 18: Make HTMLEditRules::ChangeIndentation() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244950/#review251710

Comment 117

[Makoto Kato [:m_kato]]

Comment on attachment 8976848 [details]
Bug 1460509 - part 19: Make HTMLEditRules::AlignBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244952/#review251732

Comment 118

[Makoto Kato [:m_kato]]

Comment on attachment 8976849 [details]
Bug 1460509 - part 20: Make HTMLEditRules::MakeSureElemStartsAndEndsOnCR() and HTMLEditRules::MakeSureElemStartsOrEndsOnCR() return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

https://reviewboard.mozilla.org/r/244954/#review251734

Comment 119

[Makoto Kato [:m_kato]]

Comment on attachment 8976850 [details]
Bug 1460509 - part 21: Make HTMLEditRules::RemoveAlignment() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244956/#review251736

Comment 120

[Makoto Kato [:m_kato]]

Comment on attachment 8976851 [details]
Bug 1460509 - part 22: Mark HTMLEditRules::InsertBRIfNeededInternal() and its wrappers as MOZ_MUST_USE

https://reviewboard.mozilla.org/r/244958/#review251738

Comment 121

[Makoto Kato [:m_kato]]

Comment on attachment 8976852 [details]
Bug 1460509 - part 23: Make HTMLEditRules::RemoveListStructure() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244960/#review251740

Comment 122

[Makoto Kato [:m_kato]]

Comment on attachment 8976853 [details]
Bug 1460509 - part 24: Make HTMLEditRules::PopListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244962/#review251742

Comment 123

[Makoto Kato [:m_kato]]

Comment on attachment 8976854 [details]
Bug 1460509 - part 25: Make HTMLEditRules::RemoveEmptyNodes() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244964/#review251746

Comment 124

[Makoto Kato [:m_kato]]

Comment on attachment 8976855 [details]
Bug 1460509 - part 26: Make HTMLEditRules::AdjustSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244966/#review251748

Comment 125

[Makoto Kato [:m_kato]]

Comment on attachment 8976856 [details]
Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244968/#review251750

::: editor/libeditor/HTMLEditRules.cpp:8727
(Diff revision 1)
>    } else {
>      atStartOfBlock.Set(tmp, 0);
>    }
>    ErrorResult error;
>    SelectionRef().Collapse(atStartOfBlock, error);
> +  if (NS_WARN_IF(!CanHandleEditAction())) {

need error.SuppressException();

Comment 126

[Makoto Kato [:m_kato]]

Comment on attachment 8976857 [details]
Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244970/#review251752

Comment 127

[Makoto Kato [:m_kato]]

Comment on attachment 8976858 [details]
Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244972/#review251754

Comment 128

[Makoto Kato [:m_kato]]

Comment on attachment 8976859 [details]
Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244974/#review251756

Comment 129

[Makoto Kato [:m_kato]]

Comment on attachment 8976860 [details]
Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244976/#review251758

Comment 130

[Makoto Kato [:m_kato]]

Comment on attachment 8976861 [details]
Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case

https://reviewboard.mozilla.org/r/244978/#review251764

Comment 131

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976846 [details]
Bug 1460509 - part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor

https://reviewboard.mozilla.org/r/244948/#review251708

> Need error.SuppressException() when you check destroyed at first.  If error.Failed() is true, it causes assertion.

Thanks!

Comment 132

[Makoto Kato [:m_kato]]

Comment on attachment 8976862 [details]
Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244980/#review251770

Comment 133

[Makoto Kato [:m_kato]]

Comment on attachment 8976863 [details]
Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244982/#review251772

Comment 134

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976856 [details]
Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244968/#review251750

> need error.SuppressException();

Thanks! I'll check all code after instantiating ErrorResult before posting new patches.

Comment 135

[Makoto Kato [:m_kato]]

Comment on attachment 8976864 [details]
Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244984/#review251782

Comment 136

[Makoto Kato [:m_kato]]

Comment on attachment 8976865 [details]
Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244986/#review251784

Comment 137

[Makoto Kato [:m_kato]]

Comment on attachment 8976866 [details]
Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244988/#review251794

Comment 138

[Makoto Kato [:m_kato]]

Comment on attachment 8976867 [details]
Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244990/#review251802

Comment 139

[Makoto Kato [:m_kato]]

Comment on attachment 8976868 [details]
Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244992/#review251804

Comment 140

[Makoto Kato [:m_kato]]

Comment on attachment 8976869 [details]
Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244994/#review251806

Comment 141

[Makoto Kato [:m_kato]]

Comment on attachment 8976870 [details]
Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244996/#review251808

::: editor/libeditor/HTMLEditRules.cpp:7499
(Diff revision 1)
>          return NS_ERROR_FAILURE;
>        }
>        // Put selection after break
>        ErrorResult error;
>        SelectionRef().Collapse(afterSibling, error);
> +      if (NS_WARN_IF(!CanHandleEditAction())) {

need error.SuppressException();

Comment 142

[Makoto Kato [:m_kato]]

Comment on attachment 8976871 [details]
Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244998/#review251810

Comment 143

[Makoto Kato [:m_kato]]

Comment on attachment 8976872 [details]
Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245000/#review251812

Comment 144

[Makoto Kato [:m_kato]]

Comment on attachment 8976873 [details]
Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

https://reviewboard.mozilla.org/r/245002/#review251816

Comment 145

[Makoto Kato [:m_kato]]

Comment on attachment 8976874 [details]
Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection

https://reviewboard.mozilla.org/r/245004/#review251818

Comment 146

[Makoto Kato [:m_kato]]

Comment on attachment 8976875 [details]
Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245006/#review251820

Comment 147

[Makoto Kato [:m_kato]]

Comment on attachment 8976876 [details]
Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245008/#review251822

Comment 148

[Makoto Kato [:m_kato]]

Comment on attachment 8976877 [details]
Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245010/#review251840

::: editor/libeditor/HTMLEditRules.cpp:5973
(Diff revision 1)
> -            return NS_ERROR_FAILURE;
> +          return NS_ERROR_FAILURE;
> -          }
> +        }
> -          // Adjust selection to be right before it
> -          ErrorResult error;
> +        ErrorResult error;
> -          SelectionRef().Collapse(EditorRawDOMPoint(brElement), error);
> +        SelectionRef().Collapse(EditorRawDOMPoint(brElement), error);
> +        if (NS_WARN_IF(!CanHandleEditAction())) {

need error.SuppressException();

Comment 149

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1460509 - part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult

HTMLEditRules::GetNodesFromPoint() uses ErrorResult only for checking in
debug build.  So, it should use IgnoredErrorResult instead.

Review commit: https://reviewboard.mozilla.org/r/245726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245726/

Comment 150

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976830 [details]
Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244916/diff/1-2/

Comment 151

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976831 [details]
Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244918/diff/1-2/

Comment 152

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976832 [details]
Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244920/diff/1-2/

Comment 153

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976833 [details]
Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244922/diff/1-2/

Comment 154

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976834 [details]
Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244924/diff/1-2/

Comment 155

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976835 [details]
Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244926/diff/1-2/

Comment 156

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976836 [details]
Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244928/diff/1-2/

Comment 157

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976837 [details]
Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244930/diff/1-2/

Comment 158

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976838 [details]
Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244932/diff/1-2/

Comment 159

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976839 [details]
Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244934/diff/1-2/

Comment 160

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976840 [details]
Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244936/diff/1-2/

Comment 161

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976841 [details]
Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244938/diff/1-2/

Comment 162

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976842 [details]
Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244940/diff/1-2/

Comment 163

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976843 [details]
Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244942/diff/1-2/

Comment 164

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976844 [details]
Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244944/diff/1-2/

Comment 165

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976845 [details]
Bug 1460509 - part 16: Make HTMLEditRules::DidAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244946/diff/1-2/

Comment 166

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976846 [details]
Bug 1460509 - part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244948/diff/1-2/

Comment 167

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976847 [details]
Bug 1460509 - part 18: Make HTMLEditRules::ChangeIndentation() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244950/diff/1-2/

Comment 168

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976848 [details]
Bug 1460509 - part 19: Make HTMLEditRules::AlignBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244952/diff/1-2/

Comment 169

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976849 [details]
Bug 1460509 - part 20: Make HTMLEditRules::MakeSureElemStartsAndEndsOnCR() and HTMLEditRules::MakeSureElemStartsOrEndsOnCR() return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244954/diff/1-2/

Comment 170

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976850 [details]
Bug 1460509 - part 21: Make HTMLEditRules::RemoveAlignment() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244956/diff/1-2/

Comment 171

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976851 [details]
Bug 1460509 - part 22: Mark HTMLEditRules::InsertBRIfNeededInternal() and its wrappers as MOZ_MUST_USE

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244958/diff/1-2/

Comment 172

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976852 [details]
Bug 1460509 - part 23: Make HTMLEditRules::RemoveListStructure() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244960/diff/1-2/

Comment 173

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976853 [details]
Bug 1460509 - part 24: Make HTMLEditRules::PopListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244962/diff/1-2/

Comment 174

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976854 [details]
Bug 1460509 - part 25: Make HTMLEditRules::RemoveEmptyNodes() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244964/diff/1-2/

Comment 175

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976855 [details]
Bug 1460509 - part 26: Make HTMLEditRules::AdjustSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244966/diff/1-2/

Comment 176

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976856 [details]
Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244968/diff/1-2/

Comment 177

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976857 [details]
Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244970/diff/1-2/

Comment 178

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976858 [details]
Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244972/diff/1-2/

Comment 179

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976859 [details]
Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244974/diff/1-2/

Comment 180

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976860 [details]
Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244976/diff/1-2/

Comment 181

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976861 [details]
Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244978/diff/1-2/

Comment 182

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976862 [details]
Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244980/diff/1-2/

Comment 183

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976863 [details]
Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244982/diff/1-2/

Comment 184

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976864 [details]
Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244984/diff/1-2/

Comment 185

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976865 [details]
Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244986/diff/1-2/

Comment 186

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976866 [details]
Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244988/diff/1-2/

Comment 187

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976867 [details]
Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244990/diff/1-2/

Comment 188

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976868 [details]
Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244992/diff/1-2/

Comment 189

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976869 [details]
Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244994/diff/1-2/

Comment 190

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976870 [details]
Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244996/diff/1-2/

Comment 191

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976871 [details]
Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244998/diff/1-2/

Comment 192

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976872 [details]
Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245000/diff/1-2/

Comment 193

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976873 [details]
Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245002/diff/1-2/

Comment 194

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976874 [details]
Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245004/diff/1-2/

Comment 195

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976875 [details]
Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245006/diff/1-2/

Comment 196

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976876 [details]
Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245008/diff/1-2/

Comment 197

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976877 [details]
Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245010/diff/1-2/

Comment 198

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976878 [details]
Bug 1460509 - part 49: Make HTMLEditRules::SplitMailCites() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245012/diff/1-2/

Comment 199

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976879 [details]
Bug 1460509 - part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245014/diff/1-2/

Comment 200

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976880 [details]
Bug 1460509 - part 51: Make HTMLEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245016/diff/1-2/

Comment 201

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976881 [details]
Bug 1460509 - part 52: Make HTMLEditRules::LoadHTML() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245018/diff/1-2/

Comment 202

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976882 [details]
Bug 1460509 - part 53: Make HTMLEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245020/diff/1-2/

Comment 203

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976883 [details]
Bug 1460509 - part 54: Make HTMLEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245022/diff/1-2/

Comment 204

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976884 [details]
Bug 1460509 - part 55: Make HTMLEditRules::AfterEditInner() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245024/diff/1-2/

Comment 205

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976885 [details]
Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245026/diff/1-2/

Comment 206

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976886 [details]
Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245028/diff/1-2/

Comment 207

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976887 [details]
Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245030/diff/1-2/

Comment 208

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976888 [details]
Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245032/diff/1-2/

Comment 209

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976889 [details]
Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245034/diff/1-2/

Comment 210

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976890 [details]
Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245036/diff/1-2/

Comment 211

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976891 [details]
Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245038/diff/1-2/

Comment 212

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976892 [details]
Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245040/diff/1-2/

Comment 213

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976893 [details]
Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245042/diff/1-2/

Comment 214

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976894 [details]
Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245044/diff/1-2/

Comment 215

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976895 [details]
Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245046/diff/1-2/

Comment 216

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976896 [details]
Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245048/diff/1-2/

Comment 217

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976897 [details]
Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245050/diff/1-2/

Comment 218

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976898 [details]
Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245052/diff/1-2/

Comment 219

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976899 [details]
Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245054/diff/1-2/

Comment 220

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976900 [details]
Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245056/diff/1-2/

Comment 221

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976901 [details]
Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245058/diff/1-2/

Comment 222

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976902 [details]
Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245060/diff/1-2/

Comment 223

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976903 [details]
Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245062/diff/1-2/

Comment 224

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976904 [details]
Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245064/diff/1-2/

Comment 225

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976905 [details]
Bug 1460509 - part 76: Mark HTMLEditRules::MoveContents() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245066/diff/1-2/

Comment 226

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976906 [details]
Bug 1460509 - part 77: Make HTMLEditRules::MoveNodeSmart() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245068/diff/1-2/

Comment 227

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976907 [details]
Bug 1460509 - part 78: Make HTMLEditRules::MoveBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245070/diff/1-2/

Comment 228

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976908 [details]
Bug 1460509 - part 79: Make HTMLEditRules::TryToJoinBlocksWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245072/diff/1-2/

Comment 229

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976909 [details]
Bug 1460509 - part 80: Make HTMLEditRules::DeleteNodeIfCollapsedText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245074/diff/1-2/

Comment 230

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976910 [details]
Bug 1460509 - part 81: Make HTMLEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245076/diff/1-2/

Comment 231

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976911 [details]
Bug 1460509 - part 82: Refine comments of TextEditRules.h and HTMLEditRules.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245078/diff/1-2/

Comment 232

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976912 [details]
Bug 1460509 - part 83: Make HTMLEditRules::InsertBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245080/diff/1-2/

Comment 233

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47436ee312bf5a9537653926490f5e1b85c99db4

Comment 234

[Makoto Kato [:m_kato]]

Comment on attachment 8976878 [details]
Bug 1460509 - part 49: Make HTMLEditRules::SplitMailCites() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245012/#review251992

Comment 235

[Makoto Kato [:m_kato]]

Comment on attachment 8976879 [details]
Bug 1460509 - part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245014/#review251996

Comment 236

[Makoto Kato [:m_kato]]

Comment on attachment 8976879 [details]
Bug 1460509 - part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245014/#review251998

Comment 237

[Makoto Kato [:m_kato]]

Comment on attachment 8976880 [details]
Bug 1460509 - part 51: Make HTMLEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245016/#review252000

Comment 238

[Makoto Kato [:m_kato]]

Comment on attachment 8976881 [details]
Bug 1460509 - part 52: Make HTMLEditRules::LoadHTML() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245018/#review252002

Comment 239

[Makoto Kato [:m_kato]]

Comment on attachment 8976882 [details]
Bug 1460509 - part 53: Make HTMLEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245020/#review252004

::: editor/libeditor/HTMLEditRules.h:171
(Diff revision 2)
> +   * @param aMaxLength          The maximum string length which the editor
> +   *                            allows to set.
> +   */
> +  MOZ_MUST_USE nsresult
> +  WillInsertText(EditAction aAction, bool* aCancel, bool* aHandled,
> +                 const nsAString* inString, nsAString* outString,

Although I will handle by another new bug, outString and aMaxLength are unused.

::: editor/libeditor/HTMLEditRules.h:171
(Diff revision 2)
> +   * @param aMaxLength          The maximum string length which the editor
> +   *                            allows to set.
> +   */
> +  MOZ_MUST_USE nsresult
> +  WillInsertText(EditAction aAction, bool* aCancel, bool* aHandled,
> +                 const nsAString* inString, nsAString* outString,

Although I will handle by another new bug, outString and aMaxLength are unused.

Comment 240

[Makoto Kato [:m_kato]]

Comment on attachment 8976883 [details]
Bug 1460509 - part 54: Make HTMLEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245022/#review252006

Comment 241

[Makoto Kato [:m_kato]]

Comment on attachment 8976884 [details]
Bug 1460509 - part 55: Make HTMLEditRules::AfterEditInner() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245024/#review252008

Comment 242

[Makoto Kato [:m_kato]]

Comment on attachment 8976885 [details]
Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245026/#review252010

Comment 243

[Makoto Kato [:m_kato]]

Comment on attachment 8976886 [details]
Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor

https://reviewboard.mozilla.org/r/245028/#review252012

Comment 244

[Makoto Kato [:m_kato]]

Comment on attachment 8976887 [details]
Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245030/#review252016

Comment 245

[Makoto Kato [:m_kato]]

Comment on attachment 8976888 [details]
Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245032/#review252020

::: editor/libeditor/HTMLEditRules.cpp:5532
(Diff revision 2)
>      return NS_ERROR_FAILURE;
>    }
>    nsCOMPtr<nsINode> node = firstRange->GetStartContainer();
>    int32_t offset = firstRange->StartOffset();
>  
> -  nsCOMPtr<Element> rootElement = aDoc.GetRootElement();
> +  nsCOMPtr<Element> rootElement = aDocument.GetRootElement();

RefPtr is better

Comment 246

[Makoto Kato [:m_kato]]

Comment on attachment 8976889 [details]
Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245034/#review252022

Comment 247

[Makoto Kato [:m_kato]]

Comment on attachment 8976890 [details]
Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245036/#review252040

Comment 248

[Makoto Kato [:m_kato]]

Comment on attachment 8976891 [details]
Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245038/#review252046

Comment 249

[Makoto Kato [:m_kato]]

Comment on attachment 8976892 [details]
Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245040/#review252052

Comment 250

[Makoto Kato [:m_kato]]

Comment on attachment 8976893 [details]
Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245042/#review252062

Comment 251

[Makoto Kato [:m_kato]]

Comment on attachment 8976894 [details]
Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245044/#review252066

Comment 252

[Makoto Kato [:m_kato]]

Comment on attachment 8976895 [details]
Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245046/#review252070

Comment 253

[Makoto Kato [:m_kato]]

Comment on attachment 8976896 [details]
Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245048/#review252074

Comment 254

[Makoto Kato [:m_kato]]

Comment on attachment 8976897 [details]
Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245050/#review252082

Comment 255

[Makoto Kato [:m_kato]]

Comment on attachment 8976898 [details]
Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245052/#review252094

Comment 256

[Makoto Kato [:m_kato]]

Comment on attachment 8976899 [details]
Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245054/#review252096

Comment 257

[Makoto Kato [:m_kato]]

Comment on attachment 8976900 [details]
Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245056/#review252098

Comment 258

[Makoto Kato [:m_kato]]

Comment on attachment 8976901 [details]
Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245058/#review252100

Comment 259

[Makoto Kato [:m_kato]]

Comment on attachment 8976902 [details]
Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245060/#review252102

Comment 260

[Makoto Kato [:m_kato]]

Comment on attachment 8976903 [details]
Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245062/#review252104

Comment 261

[Makoto Kato [:m_kato]]

Comment on attachment 8976904 [details]
Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245064/#review252106

Comment 262

[Makoto Kato [:m_kato]]

Comment on attachment 8976905 [details]
Bug 1460509 - part 76: Mark HTMLEditRules::MoveContents() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

https://reviewboard.mozilla.org/r/245066/#review252108

Comment 263

[Makoto Kato [:m_kato]]

Comment on attachment 8976856 [details]
Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/244968/#review251780

Comment 264

[Makoto Kato [:m_kato]]

Comment on attachment 8976906 [details]
Bug 1460509 - part 77: Make HTMLEditRules::MoveNodeSmart() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245068/#review252146

Comment 265

[Makoto Kato [:m_kato]]

Comment on attachment 8976907 [details]
Bug 1460509 - part 78: Make HTMLEditRules::MoveBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245070/#review252148

Comment 266

[Makoto Kato [:m_kato]]

Comment on attachment 8976908 [details]
Bug 1460509 - part 79: Make HTMLEditRules::TryToJoinBlocksWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245072/#review252154

Comment 267

[Makoto Kato [:m_kato]]

Comment on attachment 8976909 [details]
Bug 1460509 - part 80: Make HTMLEditRules::DeleteNodeIfCollapsedText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245074/#review252158

Comment 268

[Makoto Kato [:m_kato]]

Comment on attachment 8976910 [details]
Bug 1460509 - part 81: Make HTMLEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245076/#review252160

Comment 269

[Makoto Kato [:m_kato]]

Comment on attachment 8976911 [details]
Bug 1460509 - part 82: Refine comments of TextEditRules.h and HTMLEditRules.h

https://reviewboard.mozilla.org/r/245078/#review252170

Comment 270

[Makoto Kato [:m_kato]]

Comment on attachment 8976912 [details]
Bug 1460509 - part 83: Make HTMLEditRules::InsertBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

https://reviewboard.mozilla.org/r/245080/#review252172

Comment 271

[Makoto Kato [:m_kato]]

Comment on attachment 8979586 [details]
Bug 1460509 - part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult

https://reviewboard.mozilla.org/r/245726/#review252174

Comment 272

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976830 [details]
Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244916/diff/2-3/

Comment 273

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976831 [details]
Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244918/diff/2-3/

Comment 274

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976832 [details]
Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244920/diff/2-3/

Comment 275

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976833 [details]
Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244922/diff/2-3/

Comment 276

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976834 [details]
Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244924/diff/2-3/

Comment 277

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976835 [details]
Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244926/diff/2-3/

Comment 278

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976836 [details]
Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244928/diff/2-3/

Comment 279

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976837 [details]
Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244930/diff/2-3/

Comment 280

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976838 [details]
Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244932/diff/2-3/

Comment 281

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976839 [details]
Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244934/diff/2-3/

Comment 282

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976840 [details]
Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244936/diff/2-3/

Comment 283

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976841 [details]
Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244938/diff/2-3/

Comment 284

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976842 [details]
Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244940/diff/2-3/

Comment 285

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976843 [details]
Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244942/diff/2-3/

Comment 286

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976844 [details]
Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244944/diff/2-3/

Comment 287

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976845 [details]
Bug 1460509 - part 16: Make HTMLEditRules::DidAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244946/diff/2-3/

Comment 288

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976846 [details]
Bug 1460509 - part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244948/diff/2-3/

Comment 289

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976847 [details]
Bug 1460509 - part 18: Make HTMLEditRules::ChangeIndentation() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244950/diff/2-3/

Comment 290

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976848 [details]
Bug 1460509 - part 19: Make HTMLEditRules::AlignBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244952/diff/2-3/

Comment 291

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976849 [details]
Bug 1460509 - part 20: Make HTMLEditRules::MakeSureElemStartsAndEndsOnCR() and HTMLEditRules::MakeSureElemStartsOrEndsOnCR() return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244954/diff/2-3/

Comment 292

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976850 [details]
Bug 1460509 - part 21: Make HTMLEditRules::RemoveAlignment() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244956/diff/2-3/

Comment 293

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976851 [details]
Bug 1460509 - part 22: Mark HTMLEditRules::InsertBRIfNeededInternal() and its wrappers as MOZ_MUST_USE

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244958/diff/2-3/

Comment 294

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976852 [details]
Bug 1460509 - part 23: Make HTMLEditRules::RemoveListStructure() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244960/diff/2-3/

Comment 295

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976853 [details]
Bug 1460509 - part 24: Make HTMLEditRules::PopListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244962/diff/2-3/

Comment 296

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976854 [details]
Bug 1460509 - part 25: Make HTMLEditRules::RemoveEmptyNodes() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244964/diff/2-3/

Comment 297

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976855 [details]
Bug 1460509 - part 26: Make HTMLEditRules::AdjustSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244966/diff/2-3/

Comment 298

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976856 [details]
Bug 1460509 - part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244968/diff/2-3/

Comment 299

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976857 [details]
Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244970/diff/2-3/

Comment 300

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976858 [details]
Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244972/diff/2-3/

Comment 301

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976859 [details]
Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244974/diff/2-3/

Comment 302

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976860 [details]
Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244976/diff/2-3/

Comment 303

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976861 [details]
Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244978/diff/2-3/

Comment 304

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976862 [details]
Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244980/diff/2-3/

Comment 305

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976863 [details]
Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244982/diff/2-3/

Comment 306

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976864 [details]
Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244984/diff/2-3/

Comment 307

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976865 [details]
Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244986/diff/2-3/

Comment 308

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976866 [details]
Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244988/diff/2-3/

Comment 309

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976867 [details]
Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244990/diff/2-3/

Comment 310

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976868 [details]
Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244992/diff/2-3/

Comment 311

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976869 [details]
Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244994/diff/2-3/

Comment 312

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976870 [details]
Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244996/diff/2-3/

Comment 313

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976871 [details]
Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244998/diff/2-3/

Comment 314

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976872 [details]
Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245000/diff/2-3/

Comment 315

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976873 [details]
Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245002/diff/2-3/

Comment 316

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976874 [details]
Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245004/diff/2-3/

Comment 317

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976875 [details]
Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245006/diff/2-3/

Comment 318

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976876 [details]
Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245008/diff/2-3/

Comment 319

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976877 [details]
Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245010/diff/2-3/

Comment 320

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976878 [details]
Bug 1460509 - part 49: Make HTMLEditRules::SplitMailCites() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245012/diff/2-3/

Comment 321

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976879 [details]
Bug 1460509 - part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245014/diff/2-3/

Comment 322

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976880 [details]
Bug 1460509 - part 51: Make HTMLEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245016/diff/2-3/

Comment 323

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976881 [details]
Bug 1460509 - part 52: Make HTMLEditRules::LoadHTML() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245018/diff/2-3/

Comment 324

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976882 [details]
Bug 1460509 - part 53: Make HTMLEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245020/diff/2-3/

Comment 325

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976883 [details]
Bug 1460509 - part 54: Make HTMLEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245022/diff/2-3/

Comment 326

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976884 [details]
Bug 1460509 - part 55: Make HTMLEditRules::AfterEditInner() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245024/diff/2-3/

Comment 327

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976885 [details]
Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245026/diff/2-3/

Comment 328

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976886 [details]
Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245028/diff/2-3/

Comment 329

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976887 [details]
Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245030/diff/2-3/

Comment 330

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976888 [details]
Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245032/diff/2-3/

Comment 331

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976889 [details]
Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245034/diff/2-3/

Comment 332

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976890 [details]
Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245036/diff/2-3/

Comment 333

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976891 [details]
Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245038/diff/2-3/

Comment 334

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976892 [details]
Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245040/diff/2-3/

Comment 335

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976893 [details]
Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245042/diff/2-3/

Comment 336

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976894 [details]
Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245044/diff/2-3/

Comment 337

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976895 [details]
Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245046/diff/2-3/

Comment 338

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976896 [details]
Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245048/diff/2-3/

Comment 339

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976897 [details]
Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245050/diff/2-3/

Comment 340

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976898 [details]
Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245052/diff/2-3/

Comment 341

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976899 [details]
Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245054/diff/2-3/

Comment 342

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976900 [details]
Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245056/diff/2-3/

Comment 343

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976901 [details]
Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245058/diff/2-3/

Comment 344

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976902 [details]
Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245060/diff/2-3/

Comment 345

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976903 [details]
Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245062/diff/2-3/

Comment 346

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976904 [details]
Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245064/diff/2-3/

Comment 347

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976905 [details]
Bug 1460509 - part 76: Mark HTMLEditRules::MoveContents() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245066/diff/2-3/

Comment 348

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976906 [details]
Bug 1460509 - part 77: Make HTMLEditRules::MoveNodeSmart() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245068/diff/2-3/

Comment 349

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976907 [details]
Bug 1460509 - part 78: Make HTMLEditRules::MoveBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245070/diff/2-3/

Comment 350

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976908 [details]
Bug 1460509 - part 79: Make HTMLEditRules::TryToJoinBlocksWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245072/diff/2-3/

Comment 351

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976909 [details]
Bug 1460509 - part 80: Make HTMLEditRules::DeleteNodeIfCollapsedText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245074/diff/2-3/

Comment 352

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976910 [details]
Bug 1460509 - part 81: Make HTMLEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245076/diff/2-3/

Comment 353

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976911 [details]
Bug 1460509 - part 82: Refine comments of TextEditRules.h and HTMLEditRules.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245078/diff/2-3/

Comment 354

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8976912 [details]
Bug 1460509 - part 83: Make HTMLEditRules::InsertBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245080/diff/2-3/

Comment 355

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8979586 [details]
Bug 1460509 - part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245726/diff/1-2/

Comment 356

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5afcbdbea9d
part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0899d038b7f3
part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result r=m_kato
https://hg.mozilla.org/integration/autoland/rev/74c8cf6f92ba
part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/11bcaf374f3f
part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/96c4dd5af3c5
part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3dcc53c8a9fa
part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a150cf6057a4
part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/263d02ec8c98
part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/4ae685aae84c
part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/565fadbff87e
part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ece3aca10543
part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/54e551b4a5cd
part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/67892070f7cc
part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e9a4f9a25edc
part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/2026d755e6b7
part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf291a1b8c9c
part 16: Make HTMLEditRules::DidAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c2322ad44783
part 17: Make HTMLEditRules::WillAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the HTML editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a737ec819707
part 18: Make HTMLEditRules::ChangeIndentation() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ba7cf7a4465e
part 19: Make HTMLEditRules::AlignBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/2f7af16c2b10
part 20: Make HTMLEditRules::MakeSureElemStartsAndEndsOnCR() and HTMLEditRules::MakeSureElemStartsOrEndsOnCR() return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/54843b7bec1c
part 21: Make HTMLEditRules::RemoveAlignment() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e710e312b2fe
part 22: Mark HTMLEditRules::InsertBRIfNeededInternal() and its wrappers as MOZ_MUST_USE r=m_kato
https://hg.mozilla.org/integration/autoland/rev/005999e8351b
part 23: Make HTMLEditRules::RemoveListStructure() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/fbd3325fbcb5
part 24: Make HTMLEditRules::PopListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9f2d3bb7ea3b
part 25: Make HTMLEditRules::RemoveEmptyNodes() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e1b59994fcdf
part 26: Make HTMLEditRules::AdjustSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e0d5244b2df0
part 27: Make HTMLEditRules::PinSelectionToNewBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c5795680e2e5
part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/849fd2e02f49
part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf4b4e10743a
part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/4fd392df467a
part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7d02aaf267cb
part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a14b5f8ba603
part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ddefda4491bf
part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/184edb194ab1
part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/4a0df770d2eb
part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f11b80ec5588
part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8eb37e9acd9c
part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/eeddbabe7d63
part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/61a02140bb8b
part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5d6cf5da5865
part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/58f4a99c292c
part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/02124d51cedd
part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7c1f8f9fa414
part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8ca686e6da6f
part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5ea7f397e23e
part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0678e06a7ea6
part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ff067dd16d73
part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c722a0e44557
part 49: Make HTMLEditRules::SplitMailCites() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/bc12043b2467
part 50: Make HTMLEditRules::InsertBRElement() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/18f4358e8a2f
part 51: Make HTMLEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0bb996c7ff8b
part 52: Make HTMLEditRules::LoadHTML() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/aa6211a6af08
part 53: Make HTMLEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf364896afae
part 54: Make HTMLEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/475aebb16e98
part 55: Make HTMLEditRules::AfterEditInner() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/16607c5a025e
part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c466a8f7aad1
part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/be0e207012c7
part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6c3bf8e68459
part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/652ad712e5f5
part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/70b3b23f52cc
part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/2b159539ca98
part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/36cfdc7e03be
part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a3c1d0cf1da4
part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c6a3a026bba6
part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ed72e2f3ab7c
part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/142694da8847
part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/120c79b50985
part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/242060772656
part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/984364973122
part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/dfbf49ef76c7
part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e06c08948932
part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/1a32186e3efc
part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7fca98e9e705
part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b29fda2fff6f
part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b332308167b8
part 76: Mark HTMLEditRules::MoveContents() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r=m_kato
https://hg.mozilla.org/integration/autoland/rev/41053f306d83
part 77: Make HTMLEditRules::MoveNodeSmart() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/379371a40bb4
part 78: Make HTMLEditRules::MoveBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3c13e1f11e7e
part 79: Make HTMLEditRules::TryToJoinBlocksWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/4409da405ebb
part 80: Make HTMLEditRules::DeleteNodeIfCollapsedText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/791b270d8627
part 81: Make HTMLEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8f78ebb1fbff
part 82: Refine comments of TextEditRules.h and HTMLEditRules.h r=m_kato
https://hg.mozilla.org/integration/autoland/rev/694373e8dfd9
part 83: Make HTMLEditRules::InsertBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6f56718bd4ec
part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult r=m_kato

Comment 357

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d5afcbdbea9d
https://hg.mozilla.org/mozilla-central/rev/0899d038b7f3
https://hg.mozilla.org/mozilla-central/rev/74c8cf6f92ba
https://hg.mozilla.org/mozilla-central/rev/11bcaf374f3f
https://hg.mozilla.org/mozilla-central/rev/96c4dd5af3c5
https://hg.mozilla.org/mozilla-central/rev/3dcc53c8a9fa
https://hg.mozilla.org/mozilla-central/rev/a150cf6057a4
https://hg.mozilla.org/mozilla-central/rev/263d02ec8c98
https://hg.mozilla.org/mozilla-central/rev/4ae685aae84c
https://hg.mozilla.org/mozilla-central/rev/565fadbff87e
https://hg.mozilla.org/mozilla-central/rev/ece3aca10543
https://hg.mozilla.org/mozilla-central/rev/54e551b4a5cd
https://hg.mozilla.org/mozilla-central/rev/67892070f7cc
https://hg.mozilla.org/mozilla-central/rev/e9a4f9a25edc
https://hg.mozilla.org/mozilla-central/rev/2026d755e6b7
https://hg.mozilla.org/mozilla-central/rev/cf291a1b8c9c
https://hg.mozilla.org/mozilla-central/rev/c2322ad44783
https://hg.mozilla.org/mozilla-central/rev/a737ec819707
https://hg.mozilla.org/mozilla-central/rev/ba7cf7a4465e
https://hg.mozilla.org/mozilla-central/rev/2f7af16c2b10
https://hg.mozilla.org/mozilla-central/rev/54843b7bec1c
https://hg.mozilla.org/mozilla-central/rev/e710e312b2fe
https://hg.mozilla.org/mozilla-central/rev/005999e8351b
https://hg.mozilla.org/mozilla-central/rev/fbd3325fbcb5
https://hg.mozilla.org/mozilla-central/rev/9f2d3bb7ea3b
https://hg.mozilla.org/mozilla-central/rev/e1b59994fcdf
https://hg.mozilla.org/mozilla-central/rev/e0d5244b2df0
https://hg.mozilla.org/mozilla-central/rev/c5795680e2e5
https://hg.mozilla.org/mozilla-central/rev/849fd2e02f49
https://hg.mozilla.org/mozilla-central/rev/cf4b4e10743a
https://hg.mozilla.org/mozilla-central/rev/4fd392df467a
https://hg.mozilla.org/mozilla-central/rev/7d02aaf267cb
https://hg.mozilla.org/mozilla-central/rev/a14b5f8ba603
https://hg.mozilla.org/mozilla-central/rev/ddefda4491bf
https://hg.mozilla.org/mozilla-central/rev/184edb194ab1
https://hg.mozilla.org/mozilla-central/rev/4a0df770d2eb
https://hg.mozilla.org/mozilla-central/rev/f11b80ec5588
https://hg.mozilla.org/mozilla-central/rev/8eb37e9acd9c
https://hg.mozilla.org/mozilla-central/rev/eeddbabe7d63
https://hg.mozilla.org/mozilla-central/rev/61a02140bb8b
https://hg.mozilla.org/mozilla-central/rev/5d6cf5da5865
https://hg.mozilla.org/mozilla-central/rev/58f4a99c292c
https://hg.mozilla.org/mozilla-central/rev/02124d51cedd
https://hg.mozilla.org/mozilla-central/rev/7c1f8f9fa414
https://hg.mozilla.org/mozilla-central/rev/8ca686e6da6f
https://hg.mozilla.org/mozilla-central/rev/5ea7f397e23e
https://hg.mozilla.org/mozilla-central/rev/0678e06a7ea6
https://hg.mozilla.org/mozilla-central/rev/ff067dd16d73
https://hg.mozilla.org/mozilla-central/rev/c722a0e44557
https://hg.mozilla.org/mozilla-central/rev/bc12043b2467
https://hg.mozilla.org/mozilla-central/rev/18f4358e8a2f
https://hg.mozilla.org/mozilla-central/rev/0bb996c7ff8b
https://hg.mozilla.org/mozilla-central/rev/aa6211a6af08
https://hg.mozilla.org/mozilla-central/rev/cf364896afae
https://hg.mozilla.org/mozilla-central/rev/475aebb16e98
https://hg.mozilla.org/mozilla-central/rev/16607c5a025e
https://hg.mozilla.org/mozilla-central/rev/c466a8f7aad1
https://hg.mozilla.org/mozilla-central/rev/be0e207012c7
https://hg.mozilla.org/mozilla-central/rev/6c3bf8e68459
https://hg.mozilla.org/mozilla-central/rev/652ad712e5f5
https://hg.mozilla.org/mozilla-central/rev/70b3b23f52cc
https://hg.mozilla.org/mozilla-central/rev/2b159539ca98
https://hg.mozilla.org/mozilla-central/rev/36cfdc7e03be
https://hg.mozilla.org/mozilla-central/rev/a3c1d0cf1da4
https://hg.mozilla.org/mozilla-central/rev/c6a3a026bba6
https://hg.mozilla.org/mozilla-central/rev/ed72e2f3ab7c
https://hg.mozilla.org/mozilla-central/rev/142694da8847
https://hg.mozilla.org/mozilla-central/rev/120c79b50985
https://hg.mozilla.org/mozilla-central/rev/242060772656
https://hg.mozilla.org/mozilla-central/rev/984364973122
https://hg.mozilla.org/mozilla-central/rev/dfbf49ef76c7
https://hg.mozilla.org/mozilla-central/rev/e06c08948932
https://hg.mozilla.org/mozilla-central/rev/1a32186e3efc
https://hg.mozilla.org/mozilla-central/rev/7fca98e9e705
https://hg.mozilla.org/mozilla-central/rev/b29fda2fff6f
https://hg.mozilla.org/mozilla-central/rev/b332308167b8
https://hg.mozilla.org/mozilla-central/rev/41053f306d83
https://hg.mozilla.org/mozilla-central/rev/379371a40bb4
https://hg.mozilla.org/mozilla-central/rev/3c13e1f11e7e
https://hg.mozilla.org/mozilla-central/rev/4409da405ebb
https://hg.mozilla.org/mozilla-central/rev/791b270d8627
https://hg.mozilla.org/mozilla-central/rev/8f78ebb1fbff
https://hg.mozilla.org/mozilla-central/rev/694373e8dfd9
https://hg.mozilla.org/mozilla-central/rev/6f56718bd4ec