Closed Bug 1460559 Opened 6 years ago Closed 6 years ago

Enable tracing of new real time logger in dom/media/webrtc/* files

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(1 file)

In order to use the new logger a source file must define the TRACING macro. Add that on dom/media/webrtc/moz.build.

This is required to profile the time  we spend MediaEngineWebRTCMicrophoneSource::NotifyInputData() [1], which contains a log message but tracing is not enabled.

[1] https://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#1187
Assignee: nobody → achronop
Rank: 19
Priority: -- → P2
See Also: → 1444976
Comment on attachment 8974665 [details]
Bug 1460559 - Enable AsyncLogger in media capture files.

https://reviewboard.mozilla.org/r/243050/#review249204

::: commit-message-b6281:1
(Diff revision 1)
> +Bug 1460559 - Enable tracing of the real time logger in webrtc files. r?pehrsons

Make it clear in the commit message that this is about media capture. "webrtc" likely comes from this using webrtc.org backends before. That's not always true now with full duplex audio.

Most webrtc code lives in media/webrtc. Including MediaPipeline, Audio/VideoConduit and more. Do we need to enable it there too?
Attachment #8974665 - Flags: review?(apehrson) → review+
Comment on attachment 8974665 [details]
Bug 1460559 - Enable AsyncLogger in media capture files.

https://reviewboard.mozilla.org/r/243050/#review249204

> Make it clear in the commit message that this is about media capture. "webrtc" likely comes from this using webrtc.org backends before. That's not always true now with full duplex audio.
> 
> Most webrtc code lives in media/webrtc. Including MediaPipeline, Audio/VideoConduit and more. Do we need to enable it there too?

It would be necessary to enable there as well if we were using the the AyncLogger in those files. I guess we can update it when/if we add some log messages in those classes.
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2c09bc9c0eb5
Enable AsyncLogger in media capture files. r=pehrsons
https://hg.mozilla.org/mozilla-central/rev/2c09bc9c0eb5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: