1460559 - Enable tracing of new real time logger in dom/media/webrtc/* files

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

In order to use the new logger a source file must define the TRACING macro. Add that on dom/media/webrtc/moz.build.

This is required to profile the time  we spend MediaEngineWebRTCMicrophoneSource::NotifyInputData() [1], which contains a log message but tracing is not enabled.

[1] https://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#1187

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1460559 - Enable AsyncLogger in media capture files.

Review commit: https://reviewboard.mozilla.org/r/243050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243050/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8974665 [details]
Bug 1460559 - Enable AsyncLogger in media capture files.

https://reviewboard.mozilla.org/r/243050/#review249204

::: commit-message-b6281:1
(Diff revision 1)
> +Bug 1460559 - Enable tracing of the real time logger in webrtc files. r?pehrsons

Make it clear in the commit message that this is about media capture. "webrtc" likely comes from this using webrtc.org backends before. That's not always true now with full duplex audio.

Most webrtc code lives in media/webrtc. Including MediaPipeline, Audio/VideoConduit and more. Do we need to enable it there too?

Comment 3

[Alex Chronopoulos [:achronop]]

Comment on attachment 8974665 [details]
Bug 1460559 - Enable AsyncLogger in media capture files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243050/diff/1-2/

Comment 4

[Alex Chronopoulos [:achronop]]

Comment on attachment 8974665 [details]
Bug 1460559 - Enable AsyncLogger in media capture files.

https://reviewboard.mozilla.org/r/243050/#review249204

> Make it clear in the commit message that this is about media capture. "webrtc" likely comes from this using webrtc.org backends before. That's not always true now with full duplex audio.
> 
> Most webrtc code lives in media/webrtc. Including MediaPipeline, Audio/VideoConduit and more. Do we need to enable it there too?

It would be necessary to enable there as well if we were using the the AyncLogger in those files. I guess we can update it when/if we add some log messages in those classes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c09bc9c0eb5
Enable AsyncLogger in media capture files. r=pehrsons

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2c09bc9c0eb5