Figure out why server timing parsing tests are failing

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: valentin.gosu, Assigned: u408661)

Tracking

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [necko-triaged][wptsync upstream])

Attachments

(2 attachments)

59 bytes, text/x-review-board-request
valentin.gosu
: review+
Details
59 bytes, text/x-review-board-request
jgraham
: review+
Details
Bug 1460226 makes the server timing tests run over HTTPS.
Running `./mach wpt testing/web-platform/tests/server-timing/server_timing_header-parsing.https.html` shows 6 failures. We should figure out if we need to change the parsing behaviour or if it's the tests that need fixing.
See server_timing_header-parsing.https.html.ini for the failures.
Priority: -- → P2
Whiteboard: [necko-triaged]
Comment on attachment 8983085 [details]
Bug 1460590 part 2 - Fix buggy tests.

https://reviewboard.mozilla.org/r/248584/#review255100

OK, but I haven't reviewed the spec to check that your interpretation is correct.
Attachment #8983085 - Flags: review?(james) → review+
Comment on attachment 8983084 [details]
Bug 1460590 part 1 - Fix our parsing of Server-Timing.

https://reviewboard.mozilla.org/r/248582/#review255138

Thanks!
Attachment #8983084 - Flags: review?(valentin.gosu) → review+
Valentin - given comment 4, would you mind giving the spec a double-check for me before I land, to ensure I'm not missing something that would make my interpretation wrong? Thanks.
Flags: needinfo?(valentin.gosu)
Agreed. I reviewed the spec part regarding header parsing [1] and it is consistent with the changes to 67.js and 68.js


[1] https://w3c.github.io/server-timing/#-dfn-server-timing-header-parsing-algorithm-dfn-
Flags: needinfo?(valentin.gosu)
Pushed by hurley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94b826fc4ea4
part 1 - Fix our parsing of Server-Timing. r=valentin
https://hg.mozilla.org/integration/autoland/rev/51202d93e2e3
part 2 - Fix buggy tests. r=jgraham
https://hg.mozilla.org/mozilla-central/rev/94b826fc4ea4
https://hg.mozilla.org/mozilla-central/rev/51202d93e2e3
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11435 for changes under testing/web-platform/tests
Whiteboard: [necko-triaged] → [necko-triaged][wptsync upstream]
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.