1460601 - Add custom search engine doesn't work

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath - out of office]]

Device:
OnePlus 5T (Android 8.0)
Google Pixel (Android 8.1.0)
Motorola Moto G4 (android 6.0.1)

Build: Nightly 62.0a1 (2018-05-10);
Nightly 62.0a1 (2018-05-09) - NOT affected

Steps to reproduce:
1. Go to youtube.com
2. Long tap the search bar.
3. Tap "Add search engine".

Expected result:
A custom search engine is added.

Actual result:
The "Add search engine" button is unresponsive.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

This works for me in 62 on a Pixel 2 with Android 8.1.0.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 62, though so that we will be sure to follow up.

Comment 3

[Oana Horvath [:ohorvath - out of office]]

Regression window:

Last good build: 05-09
First bad build: 05-10
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=74b75c80928d9d3b614c4004e7f3655245c73a4a&tochange=bd8a6515472696d03773c0cc359466ce21993440

Comment 5

[Mike Kaply [:mkaply]]

jchen:

Could your patch have caused this?

Comment 6

[Jan Henning [:JanH]]

Attachment: Bug 1460601 - Fix up Prompt.jsm Dispatcher retrieval.

Forgotten in bug 1459298.

Review commit: https://reviewboard.mozilla.org/r/243882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243882/

Comment 7

[Jan Henning [:JanH]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> jchen:
> 
> Could your patch have caused this?

It could.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8975626 [details]
Bug 1460601 - Fix up Prompt.jsm Dispatcher retrieval.

https://reviewboard.mozilla.org/r/243882/#review249800

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9f2468ade24
Fix up Prompt.jsm Dispatcher retrieval. r=jchen

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e9f2468ade24

Comment 11

[Oana Horvath [:ohorvath - out of office]]

Verified on Nightly (2018-05-16).
Devices:
Mi 4i (Android 5.0.2)
Nexus 9	(Android 6.0.1)