1460609 - Make sure cookies aren't saved on channel headers in the content process.

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

We also need to make sure that the netmonitor still works correctly in devtools.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1460609 - Cookies are for parents

Make sure cookies aren't saved on channel headers in the content process.
Adds test to verify that this works, and removes tests that expected cookie headers to be visible to the child.

Review commit: https://reviewboard.mozilla.org/r/246204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246204/

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8980037 [details]
Bug 1460609 - Cookies are for parents

https://reviewboard.mozilla.org/r/246204/#review253614

I didn't much check the test....

::: netwerk/test/unit_ipc/xpcshell.ini
(Diff revision 1)
>  head = head_channels_clone.js
>  skip-if = toolkit == 'android'
>  support-files =
>    child_channel_id.js
>    !/netwerk/test/unit/test_XHR_redirects.js
> -  !/netwerk/test/unit/test_bug248970_cookie.js

are these removed in the patch?

::: netwerk/test/unit_ipc/xpcshell.ini
(Diff revision 1)
>    !/netwerk/test/unit/test_bug528292.js
>    !/netwerk/test/unit/test_cache-entry-id.js
>    !/netwerk/test/unit/test_cache_jar.js
>    !/netwerk/test/unit/test_cacheflags.js
>    !/netwerk/test/unit/test_channel_close.js
> -  !/netwerk/test/unit/test_cookie_header.js

and this one..

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Honza Bambas (:mayhemer) from comment #2)
> Comment on attachment 8980037 [details]
> Bug 1460609 - Cookies are for parents
> > -  !/netwerk/test/unit/test_bug248970_cookie.js
> 
> are these removed in the patch?

They are no longer needed by the unit_ipc tests, but they are still run in the non-e10s unit tests.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s bff2a5993e0de7431d0d5dcc1a6a49304de92b2a -d e942111bb149: rebasing 467093:bff2a5993e0d "Bug 1460609 - Cookies are for parents r=mayhemer" (tip)
merging netwerk/protocol/http/HttpChannelChild.cpp
merging netwerk/protocol/http/HttpChannelParent.cpp
merging netwerk/test/unit_ipc/xpcshell.ini
warning: conflicts while merging netwerk/protocol/http/HttpChannelParent.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8980037 [details]
Bug 1460609 - Cookies are for parents

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246204/diff/1-2/

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8980037 [details]
Bug 1460609 - Cookies are for parents

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246204/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b74236690ac
Cookies are for parents r=mayhemer

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7b74236690ac