1460615 - Crash in nsStyleTable::CalcDifference const

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-9668e8c5-e99c-43ad-af18-da92c0180509.
=============================================================

Small volume Mac regression, hit by 4 users on 10.12 running 62 so far: https://bit.ly/2jLXXjt. Crashes go back to at least 20180427102245, while nightly was in 61.

A few URLs listed:
* https://observador.pt/ 
* moz-extension://8741ce9f-8ba3-4e44-a0ac-02e5e6607523/background.htm

Top 10 frames of crashing thread:

0 XUL nsStyleTable::CalcDifference const layout/style/nsStyleStruct.cpp:1875
1 XUL mozilla::ComputedStyle::CalcStyleDifference layout/style/ComputedStyle.cpp:170
2 XUL Gecko_CalcStyleDifference layout/style/ServoBindings.cpp:354
3 XUL style::gecko::restyle_damage::GeckoRestyleDamage::compute_style_difference::hacf340a8674229a2 servo/components/style/gecko/restyle_damage.rs:53
4 XUL style::matching::PrivateMatchMethods::accumulate_damage_for::h071eb3f51a2e4540 servo/components/style/matching.rs:867
5 XUL style::traversal::compute_style::h7a0ba106debb6ff9 servo/components/style/matching.rs:733
6 XUL geckoservo::glue::traverse_subtree::h5e683fdce93e5ddf servo/components/style/traversal.rs:434
7 XUL geckoservo::glue::Servo_TraverseSubtree servo/ports/geckolib/glue.rs:340
8 XUL mozilla::ServoStyleSet::StyleDocument layout/style/ServoStyleSet.cpp:1015
9 XUL mozilla::RestyleManager::DoProcessPendingRestyles layout/base/RestyleManager.cpp:2969

=============================================================

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Not a lot of changes to the files on that stack around the time this regressed. Any thoughts, Emilio?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Hmm, not really, I can't think of anything that could have remotely caused this crash :(

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Crash Address is 0x0 meaning either this or aNewData is a nullptr I guess...

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Looking at the code, I don't really get how this can happen either :/

Comment 5

[Marcia Knous [:marcia]]

One additional URLs: https://www.youtube.com/watch?v=p2j1SiXyVXA

EXC_BAD_ACCESS / EXC_I386_GPFLT is the crash reason for the crashes.

Comment 6

[Cameron McCormack (:heycam)]

Low crash volume, nothing actionable so far.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.