Closed Bug 1460647 Opened 6 years ago Closed 6 years ago

Set -Wa,-mbig-obj in local builds for MinGW

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

3 Branch
enhancement

Tracking

(firefox-esr60 fixed, firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

In Bug 1440013, we set -Wa,-mbig-obj; but it's behind 'test -z "$DEVELOPER_OPTIONS"' so it doesn't get set for local builds one may do outside TaskCluster.

That is quite unfortunate, so we should move it out from behind that.
Hum. I was under the impression that the too-many-sections problem was a result of the -ffunction-sections and -fdata-sections flags earlier in the block. (Those options certainly do explode the number of sections we use.) Are you saying we have too many sections even without those flags?
No, even without ffunction-sections, I get the error:

> 2:23.69 /usr/local/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/as: Unified_cpp_dom_base5.o: too many sections (35627)
> 2:23.69 {standard input}: Assembler messages:
> 2:23.70 {standard input}: Fatal error: can't write 283 bytes to section .text of Unified_cpp_dom_base5.o because: 'File too big'
> 2:23.70 /usr/local/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/as: Unified_cpp_dom_base5.o: too many sections (35627)
> 2:23.70 {standard input}: Fatal error: can't close Unified_cpp_dom_base5.o: File too big
> 2:23.72 /home/tom/Documents/moz/mingw-work/x64-2/config/rules.mk:1047: recipe for target 'Unified_cpp_dom_base5.o' failed
> 2:23.72 make[4]: *** [Unified_cpp_dom_base5.o] Error 1
> 2:23.72 /home/tom/Documents/moz/mingw-work/x64-2/config/recurse.mk:73: recipe for target 'dom/base/target' failed
> 2:23.72 make[3]: *** [dom/base/target] Error 2
> 2:25.54 /usr/local/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/as: UnifiedBindings21.o: too many sections (41834)
> 2:25.54 {standard input}: Assembler messages:
> 2:25.54 {standard input}: Fatal error: can't write 257 bytes to section .text of UnifiedBindings21.o because: 'File too big'
> 2:25.54 /usr/local/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/as: UnifiedBindings21.o: too many sections (41834)
> 2:25.54 {standard input}: Fatal error: can't close UnifiedBindings21.o: File too big
Comment on attachment 8974745 [details]
Bug 1460647 Move big-obj out of Developer_OPTIONS so local MinGW builds work

https://reviewboard.mozilla.org/r/243118/#review250044
Attachment #8974745 - Flags: review+
Attachment #8974745 - Flags: review?(core-build-config-reviews)
Depends on: 1440013
Comment on attachment 8974745 [details]
Bug 1460647 Move big-obj out of Developer_OPTIONS so local MinGW builds work

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8974745 - Flags: approval-mozilla-esr60?
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66ae52240868
Move big-obj out of Developer_OPTIONS so local MinGW builds work r=mshal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/66ae52240868
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8974745 [details]
Bug 1460647 Move big-obj out of Developer_OPTIONS so local MinGW builds work

mingw build fix, approved for 60.1esr
Attachment #8974745 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Version: Version 3 → 3 Branch
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: