Closed Bug 1460668 Opened 6 years ago Closed 6 years ago

Bump MinGW version to fix CD3D11_BLEND_DESC definition

Categories

(Firefox Build System :: General: Unsupported Platforms, defect, P5)

Product:
Firefox Build System
Component:
General: Unsupported Platforms
Version:
3 Branch
Type:
defect

Tracking

(firefox-esr60 fixed, firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix
59 bytes, text/x-review-board-request
froydnj
: review+
jcristau
: approval-mozilla-esr60+
Details 
When `gfx.direct2d.disabled` and `layers.acceleration.disabled` are disabled (so the features are enabled) - the browser crashes.

This is the result of a MinGW bug:

> for(D3D11_RENDER_TARGET_BLEND_DESC *target; target < RenderTarget+D3D11_SIMULTANEOUS_RENDER_TARGET_COUNT; target++) {

should be

> for(D3D11_RENDER_TARGET_BLEND_DESC *target = RenderTarget; target < RenderTarget+D3D11_SIMULTANEOUS_RENDER_TARGET_COUNT; target++) {

This should just be as simple as bumping the MinGW version.
Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

https://reviewboard.mozilla.org/r/243170/#review249042
Attachment #8974766 - Flags: review?(nfroyd) → review+
Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8974766 - Flags: approval-mozilla-esr60?
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2112c371739a
Bump MinGW to capture the CD3D11_BLEND_DESC fix r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2112c371739a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

mingw update for 60.1esr
Attachment #8974766 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Version: Version 3 → 3 Branch
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: