1460668 - Bump MinGW version to fix CD3D11_BLEND_DESC definition

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect, P5)

Description

[Tom Ritter [:tjr]]

When `gfx.direct2d.disabled` and `layers.acceleration.disabled` are disabled (so the features are enabled) - the browser crashes.

This is the result of a MinGW bug:

> for(D3D11_RENDER_TARGET_BLEND_DESC *target; target < RenderTarget+D3D11_SIMULTANEOUS_RENDER_TARGET_COUNT; target++) {

should be

> for(D3D11_RENDER_TARGET_BLEND_DESC *target = RenderTarget; target < RenderTarget+D3D11_SIMULTANEOUS_RENDER_TARGET_COUNT; target++) {

This should just be as simple as bumping the MinGW version.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

Review commit: https://reviewboard.mozilla.org/r/243170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243170/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243170/diff/1-2/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

https://reviewboard.mozilla.org/r/243170/#review249042

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243170/diff/2-3/

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2112c371739a
Bump MinGW to capture the CD3D11_BLEND_DESC fix r=froydnj

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2112c371739a

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8974766 [details]
Bug 1460668 Bump MinGW to capture the CD3D11_BLEND_DESC fix

mingw update for 60.1esr

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/eb0f41ed94fb