nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: erahm, Assigned: KrisWright)

Tracking

Trunk
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently `mUnderlineStyle` is compared against `NS_STYLE_BORDER_STYLE_NONE` [1], instead we should use `NS_STYLE_TEXT_DECORATION_STYLE_NONE` [2]. This okay right now since both are 0, but we're switching NS_STYLE_BORDER_STYLE to an enum class.

[1] https://searchfox.org/mozilla-central/rev/eb6c5214a63e20a3fff455e92c876287a8d2e188/layout/generic/nsTextFrame.cpp#3992
[2] https://searchfox.org/mozilla-central/rev/eb6c5214a63e20a3fff455e92c876287a8d2e188/layout/style/nsStyleConsts.h#796
Assignee

Comment 1

a year ago
Removed comparison to NS_STYLE_BORDER_STYLE_NONE and replaced with NS_STYLE_TEXT_DECORATION_STYLE_NONE
Assignee

Updated

a year ago
Assignee: nobody → kwright
Status: NEW → ASSIGNED
Assignee

Updated

a year ago
Attachment #8974777 - Flags: review?(dbaron)
Comment on attachment 8974777 [details] [diff] [review]
nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE

This looks good -- except that it looks like this patch is on *top* of a change to convert NS_STYLE_BORDER_STYLE_* constants to StyleBorderStyle::* enums -- but it should almost certainly land *before* that patch rather than after.  (In other words, the "-" line in the patch should be different, to reflect what's currently in the tree rather than what's in the other patch.)

r=dbaron
Attachment #8974777 - Flags: review?(dbaron) → review+
Assignee

Comment 3

a year ago
Removed comparison to NS_STYLE_BORDER_STYLE_NONE and replaced with NS_STYLE_TEXT_DECORATION_STYLE_NONE
Assignee

Updated

a year ago
Attachment #8974777 - Attachment is obsolete: true
Assignee

Comment 4

a year ago
Comment on attachment 8975550 [details] [diff] [review]
nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE

Carrying forward r+ from previous review
Attachment #8975550 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e82df2064191211edf514520e8f9aa37fe9d3d
Bug 1460682 - nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE r=dbaron

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a5e82df20641
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.