Closed Bug 1460682 Opened 7 years ago Closed 7 years ago

nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: erahm, Assigned: KrisWright)

References

Details

Attachments

(1 file, 1 obsolete file)

nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE
1.06 KB, patch
KrisWright
: review+
Details | Diff | Splinter Review
Currently `mUnderlineStyle` is compared against `NS_STYLE_BORDER_STYLE_NONE` [1], instead we should use `NS_STYLE_TEXT_DECORATION_STYLE_NONE` [2]. This okay right now since both are 0, but we're switching NS_STYLE_BORDER_STYLE to an enum class. [1] https://searchfox.org/mozilla-central/rev/eb6c5214a63e20a3fff455e92c876287a8d2e188/layout/generic/nsTextFrame.cpp#3992 [2] https://searchfox.org/mozilla-central/rev/eb6c5214a63e20a3fff455e92c876287a8d2e188/layout/style/nsStyleConsts.h#796
Removed comparison to NS_STYLE_BORDER_STYLE_NONE and replaced with NS_STYLE_TEXT_DECORATION_STYLE_NONE
Assignee: nobody → kwright
Status: NEW → ASSIGNED
Attachment #8974777 - Flags: review?(dbaron)
Comment on attachment 8974777 [details] [diff] [review] nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE This looks good -- except that it looks like this patch is on *top* of a change to convert NS_STYLE_BORDER_STYLE_* constants to StyleBorderStyle::* enums -- but it should almost certainly land *before* that patch rather than after. (In other words, the "-" line in the patch should be different, to reflect what's currently in the tree rather than what's in the other patch.) r=dbaron
Attachment #8974777 - Flags: review?(dbaron) → review+
Removed comparison to NS_STYLE_BORDER_STYLE_NONE and replaced with NS_STYLE_TEXT_DECORATION_STYLE_NONE
Attachment #8974777 - Attachment is obsolete: true
Comment on attachment 8975550 [details] [diff] [review] nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE Carrying forward r+ from previous review
Attachment #8975550 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e82df2064191211edf514520e8f9aa37fe9d3d Bug 1460682 - nsSelectionStyle::mUnderlineStyle should be compared against NS_STYLE_TEXT_DECORATION_STYLE_NONE r=dbaron
https://hg.mozilla.org/mozilla-central/rev/a5e82df20641
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: