1460716 - Android artifact builds failing on try: No such file or directory: '/builds/worker/workspace/build/src/obj-firefox/dist/bin/dictionaries'

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Geoff Brown [:gbrown]]

Artifact builds on try were fine until recently, but are failing today. Builds on mozilla-central look okay.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef66747687a207c1d9009957c267223570c62f9b

https://treeherder.mozilla.org/logviewer.html#?job_id=177931183&repo=try&lineNumber=1261

[task 2018-05-10T19:15:25.392Z] 19:15:25     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.generate_builtin_addons chrome/chrome/content/built_in_addons.json
[task 2018-05-10T19:15:25.392Z] 19:15:25     INFO -  Traceback (most recent call last):
[task 2018-05-10T19:15:25.392Z] 19:15:25     INFO -    File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
[task 2018-05-10T19:15:25.392Z] 19:15:25     INFO -      "__main__", fname, loader, pkg_name)
[task 2018-05-10T19:15:25.392Z] 19:15:25     INFO -    File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2018-05-10T19:15:25.393Z] 19:15:25     INFO -      exec code in run_globals
[task 2018-05-10T19:15:25.393Z] 19:15:25     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/generate_builtin_addons.py", line 46, in <module>
[task 2018-05-10T19:15:25.393Z] 19:15:25     INFO -      sys.exit(main(sys.argv[1:]))
[task 2018-05-10T19:15:25.394Z] 19:15:25     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/generate_builtin_addons.py", line 35, in main
[task 2018-05-10T19:15:25.394Z] 19:15:25     INFO -      "dictionaries": find_dictionaries("dictionaries"),
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/generate_builtin_addons.py", line 28, in find_dictionaries
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -      for filename in os.listdir(os.path.join(bindir, path)):
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  OSError: [Errno 2] No such file or directory: '/builds/worker/workspace/build/src/obj-firefox/dist/bin/dictionaries'
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  Makefile:61: recipe for target 'features' failed
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  make[5]: *** [features] Error 1
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mobile/android/base'
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  /builds/worker/workspace/build/src/config/faster/rules.mk:74: recipe for target '/builds/worker/workspace/build/src/obj-firefox/mobile/android/base/features' failed
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  make[4]: *** [/builds/worker/workspace/build/src/obj-firefox/mobile/android/base/features] Error 2
[task 2018-05-10T19:15:25.395Z] 19:15:25     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1460716 - Make mobile/android artifact builds produce features JSON.

I don't understand how this will interact with the parts of the build
where we try to avoid installing the dist/bin manifest, but this makes
sense to me and it works locally for mobile/android and for browser/.

Review commit: https://reviewboard.mozilla.org/r/243516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243516/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8975148 [details]
Bug 1460716 - Make mobile/android artifact builds produce features JSON.

https://reviewboard.mozilla.org/r/243516/#review250024

The `features` file appears to chain up to the `default` target. So this seemingly only impacts ordering of targets currently being executed in the same group. So this seems fine.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8975148 [details]
Bug 1460716 - Make mobile/android artifact builds produce features JSON.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243516/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68b9c1aab810
Make mobile/android artifact builds produce features JSON. r=gps

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/68b9c1aab810