1460748 - WebExtension dictionaries load .dic file as affix file

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Patrick Albrecht]

Attachment: 2018-05-09.png

I noticed that that beginning with the 2018-05-10 builds the spell checking has some issues as it marks correct words wrong and suggest wrong alternatives. Please see the two screenshots for the differences between the 2018-05-10 and the 2018-05-09 build. I installed both time the same dictionary (https://addons.mozilla.org/en-US/firefox/addon/german-dictionary-de_ch-for-sp/) and also tested it with a fresh profile. I'm using macOS 10.13.3

Comment 1

[Patrick Albrecht]

Attachment: 2018-05-10.png

Comment 2

[Patrick Albrecht]

I'm marking the blocks because those are the two last changes on the dictionaries/spell check. Also ping Kris as the assignee of those bugs.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1460748: Load the correct affix file for WebExtension dictionaries.

Review commit: https://reviewboard.mozilla.org/r/243232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243232/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8974853 [details]
Bug 1460748: Load the correct affix file for WebExtension dictionaries.

https://reviewboard.mozilla.org/r/243232/#review249350

A comment in mozISpellCheckingEngine.idl indicating that `addDictionary()` takes the .aff file and derives the location of the .dic file from it would make this all marginally less obscure...

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8974853 [details]
Bug 1460748: Load the correct affix file for WebExtension dictionaries.

https://reviewboard.mozilla.org/r/243232/#review249350

Fixed.

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c617698f9edfa167bcae2babe7e68d77c47b3d68
Bug 1460748: Load the correct affix file for WebExtension dictionaries. r=aswan

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b633d573ce30768042e47b01f5698ceb8a0196d
Bug 1460748: Follow-up: Fix rebase botch. r=me,test-only DONTBUILD

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c617698f9edf
https://hg.mozilla.org/mozilla-central/rev/7b633d573ce3

Comment 9

[Patrick Albrecht]

tested with 2018-05-13 build; result is the same as in 2018-05-09.png screenshot. Bug is fixed.

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 8974853 [details]
Bug 1460748: Load the correct affix file for WebExtension dictionaries.

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This makes dictionaries more or less useless for users who it affects

User impact if declined: AMO only distributes WebExtension dictionaries at this point, and those dictionaries currently do not work properly in ESR. Stem words are detected correctly, but affixes are ignored.

Fix Landed on Version: 62

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's a trivial change to load the correct affix file when loading dictionaries. The change has been present in release builds for several versions, and only has the potential to affect dictionaries which are already not working correctly.

String or UUID changes made by this patch: None.

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8974853 [details]
Bug 1460748: Load the correct affix file for WebExtension dictionaries.

make webextension dictionaries work, approved for 60.5.0esr

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This needs a rebased patch for ESR60.

Comment 14

[Kris Maglione [:kmag]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/0857f7986f69f2981742baa9a9084a3013e56d2e

Comment 15

[CosminB]

I was able to reproduce this issue on Firefox 60.4.0esr(20181203164059) under Win 7 64-bit and  Mac OS X 10.14.1.

This issue is verified as fixed on Firefox 60.4.1esr(20190104225443) Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Comment 16

[CosminB]

Attachment: Bug1460748Fixed.png