1460796 - MinGW x64 does not launch on Windows 7: Missing entry point ScriptBreak

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr]]

When attempting to launch a x64 MinGW build on Windows 7, a dialog is immediately presented that says

> The procedure entry point ScriptBreak could not be located in the dynamic link library GDI32.dll

According to https://msdn.microsoft.com/en-us/library/windows/desktop/dd319118(v=vs.85).aspx 

> Starting with Windows 8: To maintain the ability to run on Windows 7, a module that uses Uniscribe must specify Usp10.lib before gdi32.lib in its library list.

I don't know why we don't need this for non-MinGW builds though...

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

Review commit: https://reviewboard.mozilla.org/r/243266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243266/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

https://reviewboard.mozilla.org/r/243266/#review249220

I think it's pretty peculiar that usp10 doesn't get linked in properly, because it's specified in moz.build files.  Maybe some sort of Python hashtable sorting that differs between platforms?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b463e90d8098
Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build r=froydnj

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b463e90d8098

Comment 5

[Georg Koppen]

Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

[Approval Request Comment]

This is one of several MinGW Build patches we'd like to land in esr60 for Tor.
It will prevent us from carrying our own patches for the lifetime of esr60
and will enable Mozilla to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

mingw build fix, approved for 60.1esr

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/fd7f1f6a44cd