MinGW x64 does not launch on Windows 7: Missing entry point ScriptBreak

RESOLVED FIXED in Firefox -esr60

Status

enhancement
P5
normal
RESOLVED FIXED
Last year
3 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Depends on 1 bug)

3 Branch
mozilla62
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox62 fixed)

Details

Attachments

(1 attachment)

When attempting to launch a x64 MinGW build on Windows 7, a dialog is immediately presented that says

> The procedure entry point ScriptBreak could not be located in the dynamic link library GDI32.dll

According to https://msdn.microsoft.com/en-us/library/windows/desktop/dd319118(v=vs.85).aspx 

> Starting with Windows 8: To maintain the ability to run on Windows 7, a module that uses Uniscribe must specify Usp10.lib before gdi32.lib in its library list.

I don't know why we don't need this for non-MinGW builds though...
Depends on: 1460801
Attachment #8974881 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

https://reviewboard.mozilla.org/r/243266/#review249220

I think it's pretty peculiar that usp10 doesn't get linked in properly, because it's specified in moz.build files.  Maybe some sort of Python hashtable sorting that differs between platforms?
Attachment #8974881 - Flags: review?(nfroyd) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b463e90d8098
Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b463e90d8098
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

[Approval Request Comment]

This is one of several MinGW Build patches we'd like to land in esr60 for Tor.
It will prevent us from carrying our own patches for the lifetime of esr60
and will enable Mozilla to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8974881 - Flags: approval-mozilla-esr60?
Comment on attachment 8974881 [details]
Bug 1460796 Resolve 'Missing entry point ScriptBreak' by including usp10 for the MinGW build

mingw build fix, approved for 60.1esr
Attachment #8974881 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Version: Version 3 → 3 Branch
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.