Closed
Bug 1460805
Opened 6 years ago
Closed 6 years ago
BinAST error during FB newsfeed load: "TypeError: BinAST Error: Captured variable was not declared as captured"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: vladan, Assigned: efaust)
References
Details
Attachments
(4 files, 1 obsolete file)
This is a BinAST error encountered during FB newsfeed load. It is not from my usual fb_bench newsfeed snapshot. See attached error stack (not super interesting). I attached a minimal test case. To test it: 1. Clone https://github.com/vdjeric/binast-server 2. Put the test case in the same binast-server/ directory 3. ./serveBinAST.py . 4. Load https://localhost:8443/browserlab.htm
Reporter | ||
Comment 1•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Reporter | ||
Updated•6 years ago
|
Attachment #8974894 -
Attachment is obsolete: true
Reporter | ||
Comment 2•6 years ago
|
||
Reporter | ||
Comment 3•6 years ago
|
||
Reporter | ||
Comment 4•6 years ago
|
||
Reporter | ||
Comment 5•6 years ago
|
||
Jonco: why doesn't the BinAST error bubble up to the DevTools console? I only got "Loading failed for the <script> with source <url>"
Flags: needinfo?(jcoppeard)
Assignee | ||
Comment 6•6 years ago
|
||
BinAST error is on the encoder side. Will fix and PR appropriately. Nothing more needs to be done for SM.
Yeah, definitely looks like an encoder error. If you have a PR, I'll merge it immediately.
Normally, efaust has fixed this with https://github.com/binast/binjs-ref/pull/127 .
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jcoppeard)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•