1460810 - [Wayland] - Segfault while pasting text

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Evan Klitzke]

Attachment: wayland-paste.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20180405092205

Steps to reproduce:

When Firefox is built with Wayland support, I consistently get a crash if I try to paste text on hangouts.google.com. I previously reported this issue in bug #1438136.

Attached is a patch that I generated to avoid the segfault. The issue is pretty simple, related to mixing signed/unsigned types. Note that pasting is still broken for me with this patch applied, this just prevents Firefox from segfaulting.

This is my first patch, I'm not really familiar with the process to get this merged.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8974902 [details] [diff] [review]
wayland-paste.patch

Yes, I see that, Thanks. gtk_selection_data_get_length() returns -1 when there's no selection available.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c3b4294017c
[Gtk/Wayland] Handle error value (-1) returned by gtk_section_data_get_length(), r=stransky

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8c3b4294017c