1460883 - Remove flow sensitive alias analysis option

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

In bug 1455280 flow sensitive alias analysis was removed, but the option was left behind to simplify fuzzing and bisection. Nevertheless, at some point the option should go away.

Comment 1

[Himanshuteli]

I would like to work on this can you guide me

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Hey, I'd love to guide you. 

First step: make sure you get a copy of the sources, and are able to build at least spidermonkey [1]. In my experience, using bootstrap.py is the easiest way to get ready to go [2].  

So the option used to be 'ion-aa'. A very useful tool for you is https://searchfox.org/, which will help you find the references to that option. If I recall correctly there are two of them. You'll just need to prepare a patch to excise them. 

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation
[2]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build/Linux_and_MacOS_build_preparation

Comment 3

[Himanshuteli]

I have successfully build firefox and compiled it.
If I'm correct, we need to remove the lines: 
if (op.getStringOption("ion-aa")) {}
|| !op.addStringOption('\0', "ion-aa", "flow-sensitive/flow-insensitive",
                               "Specify wheter or not to use flow sensitive Alias Analysis"
                               "(default: flow-insensitive)")
located in js/src/shell/js.cpp

Let's wait for more info.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Those look about right to me. So now, you'll do the removal, ensure things still build, then upload a patch to this bug.

Comment 5

[Himanshuteli]

Attachment: js.cpp

Removed flow sensitive alias analysis option

Comment 6

[bobslept]

(In reply to Himanshuteli from comment #5)
> Created attachment 8975864 [details] [diff] [review]
> js.cpp
> 
> Removed flow sensitive alias analysis option

Please join #introduction on irc.mozilla.org, then I will help you create a patch.

Comment 7

[bobslept]

Otherwise, this maybe helps: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 8

[Himanshuteli]

Attachment: 1460883-Remove-flow-sensitive-alias-analysis-option

Removed flow sensitive alias analysis option. I hope this patch is correct.

Comment 9

[Ted Campbell [:tcampbell]]

Comment on attachment 8979027 [details] [diff] [review]
1460883-Remove-flow-sensitive-alias-analysis-option

Review of attachment 8979027 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this! :)

Comment 10

[Ted Campbell [:tcampbell]]

If you are happy with the patch, add "checkin-needed" to the |Keywords| list (which you can edit by clicking Edit Bug near the top of page). A Sheriff will add my name to the commit message and checkin the patch for us.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5184707be08
Remove flow sensitive alias analysis option r=tcampbell

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f5184707be08

Comment 13

[Ted Campbell [:tcampbell]]

\o/ Congrats on landing your first SpiderMonkey patch!