1460892 - Mass approve doesn’t reject previous suggestions

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Pontoon, enhancement)

Description

[Théo Chevalier]

Here’s my use case, but it works with single strings too:

1. Switch to suggest mode
2. Suggest translations for a full file
3. Do several rounds of QA, you will end up with some strings having multiple suggestions.
4. Select all strings
5. Mass approve all suggestions

Currently, the latest suggestion for each string are approved, but for strings having multiple suggestions, previous suggestions are not rejected.

Examples here on prod: https://pontoon.mozilla.org/fr/engagement/emails/2018/clear_history.lang/?string=178682

And on staging: https://mozilla-pontoon-staging.herokuapp.com/fr/engagement/emails/2018/fundraising_may.lang/?string=178359

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I am not sure if this is actually a bug. Doing mass approvals you can actually miss some better suggestions, if you haven't really went through all the strings and checked what suggestions there are. Lates may not be the greatest.

With the change to unreviewed suggestions visibility, it think the current behaviour may start to make much more sense.

Comment 2

[Théo Chevalier]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #1)
> I am not sure if this is actually a bug. Doing mass approvals you can
> actually miss some better suggestions, if you haven't really went through
> all the strings and checked what suggestions there are. Lates may not be the
> greatest.
> 
> With the change to unreviewed suggestions visibility, it think the current
> behaviour may start to make much more sense.

This behavior wouldn’t be consistent with how mass reject, mass replace and approving a suggestion for a single string work and I find this confusing.

I’m curious, what would a good review workflow look like using mass approvals but whithout going through all suggestions? I think that if someone is approving suggestions, it is kind of expected s-he knows everything s-he’s approving. If that’s not the case, then a manual review should probably be used here.
Also based on how the other features work, it is expected the latest suggestion will be approved, and the others rejected.

Comment 3

[Matjaz Horvat [:mathjazz]]

I don't think the current behaviour is inconsistent with other mass actions:

1. Approve All doesn't reject inactive unreviewed suggestions.

2. Find and replace doesn't reject inactive unreviewed suggestions. It only rejects the ones being replaced (active).

3. Reject all suggestions explicitly states it's rejecting all suggestions. We'll be changing that slightly in bug 1386267.

Also, you can click "Approve All" and then "Reject all suggestions" if you want to mimic the proposed behaviour.