1460898 - Screenshots on the v12.x branch are failing

Status: RESOLVED FIXED

(Firefox for iOS :: Localization, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

There is a small compilation error that was probably left out of the Swift 4 migration. The bigger issue is that several screenshot tests are failing.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

When the tests are run, we get some feedback where the screengraph navigation is failing.

Comment 2

[:garvan]

Attachment: Pull request

Comment 3

[:garvan]

James: this is the place where the screengraph code is acting strangely. See the PR the workaround line that was needed. It seems like an XCUITest test runner bug, and not screengraph itself.

Comment 4

[:garvan]

Comment on attachment 8975096 [details] [review]
Pull request

st3fan r+'d on github,
landed on master, and v12.x (edd3d065a).

Keeping bug open until I file the follow up issues regarding 
- setting accessibility identifiers on UIAlertControllers
- the fact the test runner taps the wrong option on the tabs context menu in this test scenario, but not others

Comment 5

[:garvan]

Bug filed for ids: https://bugzilla.mozilla.org/show_bug.cgi?id=1461316

As for part 2, the test runner tapping the wrong button, unless this bug was to reoccur, I don't think it will be productive to explore why the test runner behaved strangely in just this case (both Farhan and I already spent time looking for clues and didn't find anything). It is easier to just workaround the problem, in UI testing there are many ways to accomplish the same result. 
My impression was that it was a bug in Apple's test runner.