1460922 - Support opening application menus from top-level HTML pages

Status: RESOLVED WORKSFORME

(Core :: XUL, enhancement, P5)

Description

[Brian Grinstead [:bgrins]]

We'll need to find a way to support something like the `<toolbar type="menubar"><menubar /></toolbar>` combo that renders the window menu (using DOM on Win/Linux and rendered with native menu API on OSX).

The Browser Console doesn't currently use this feature although it probably should (for the Edit menu, if nothing else).

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1460922 - Proof of concept - render XUL menu DOM inside top-level HTML document

This also demonstrates integration with Fluent, including dynamic attribute changes
It can be run with: ./mach run --temp-profile --chrome chrome://browser/content/menu-tester.html --jsconsole

Review commit: https://reviewboard.mozilla.org/r/243434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243434/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8975089 [details]
Bug 1460922 - Proof of concept - render XUL menu DOM inside top-level HTML document

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243434/diff/1-2/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8975089 [details]
Bug 1460922 - Proof of concept - render XUL menu DOM inside top-level HTML document

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243434/diff/2-3/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8975089 [details]
Bug 1460922 - Proof of concept - render XUL menu DOM inside top-level HTML document

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243434/diff/3-4/

Comment 5

[Brian Grinstead [:bgrins]]

I think this is generally working, as per the prototype patch. There may be bugs we haven't seen with it, but closing for now unless/until we find specific issues to work on.