Closed
Bug 1460957
Opened 6 years ago
Closed 6 years ago
Make inlineable isPermanentAtom,
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(2 files)
11.53 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
4.77 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Splitting off a new bug from bug 1449033 so I can land the two patches there without confusing what is and what is not fixed, especially since it seems like backporting decisions probably ought to be made independently for whatever fix shows up there vs this relatively minor tuning patch.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8975111 [details] [diff] [review] Make inlineable isPermanentAtom, Carrying over r+
Attachment #8975111 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8975112 -
Flags: review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7aa19a11e2e3 Make inlineable isPermanentAtom, r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/8fad63bd942e Make shadow::Symbol to remove mayBeOwnedByOtherRuntimeSlow, r=jonco
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7aa19a11e2e3 https://hg.mozilla.org/mozilla-central/rev/8fad63bd942e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment 6•5 years ago
|
||
It looks like this cause a 33k regression in libxul size [1]. [1] https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1299711,1,2&zoom=1526327385978.852,1526392083495.4683,129695895.52238806,130125000&selected=mozilla-inbound,1299711,337081,468827870,2
You need to log in
before you can comment on or make changes to this bug.
Description
•