Closed
Bug 1460995
Opened 7 years ago
Closed 7 years ago
Bootstrap process: CreateProcess call failing on Windows 7
Categories
(Firefox :: General, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: inj+)
Attachments
(1 file)
|
3.78 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
CreateProcess fails with ERROR_NO_SYSTEM_RESOURCES on Windows 7. It looks like the reason why is because PROC_THREAD_ATTRIBUTE_HANDLE_LIST doesn't like console handles.
We can fix this by only setting that policy (and its associated inheritable handles) when there is one or more standard handles that are *not* console handles.
Note that if all handles are console handles, we don't need to pass STARTF_USESTDHANDLES either, since they'll automatically be set to the current console.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8975175 -
Flags: review?(mhowell)
|
||
Updated•7 years ago
|
Attachment #8975175 -
Flags: review?(mhowell) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eaeadece13c52e5be48ce42e37a5679205f5a10
Bug 1460995: Bootstrap process - Ensure only file and pipe handles are passed in the PROC_THREAD_ATTRIBUTE_HANDLE_LIST; r=mhowell
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in
before you can comment on or make changes to this bug.
Description
•