1461 - URL: need to use correct base w/ relative URLS

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[pnunn]

Troy:
I'm not sure who should get this, but I know you will know.
The parsing for the url is not handling the default index.html
file properly if the slash after the last directory is omitted.

I have a simple html index page, with only an <img> tag on it.
It displays properly if the URL ends with a slash, but displays
a broken image if the slash is omitted.

ok:   http://www.best.com/~pnunn/
not ok: http://www.best.com/~pnunn

In 4.0x&Gromit versions, the url is completed with an additional '/'
so that it does the correct thing.

In xpviewer, the image url is misunderstood to be
http://www.best.com/pn_port1.jpg rather than
http://www.best.com/~pnunn/pn_port1.jpg.

In debugging, if you break as soon as an
image is requested will show a content-type of text/html since the
data stream is actually a 404 html.

Comment 1

[troy]

Pam, it works fine for me. I'm using the NGLayout "viewer". Are you using the
viewer or the xpfe?

Comment 2

[pnunn]

I'm looking at xpviewer.exe.
I've tried the bits released by sar, as well as my debug build.

If it doesn't break the first time around, go to another url and
then back. Once I do that, I can see the image or an error icon just
by adding or deleting a slash on the url.

If you still have trouble, I'll drop by.

Comment 3

[troy]

Yeah, I saw it happen when I went to a different page and then went Back

Comment 4

[troy]

I guess the problem is in URLImpl which is called by NS_MakeAbsoluteURL.
If there's no trailing '/' then the final is resolved as
http://www.best.com/pn_port1.jpg instead of ...best.com/~pnunn/pn_port1.jpg

Comment 5

[leger]

Putting on ss: radar

Comment 6

[leger]

This is a dup.  Anyone, know the bug #.

Comment 7

[leger]

Taking off ss: list per bug mtg today.  Will Release Note.  Dup of 1356?

Comment 8

[leger]

This now in Release Notes.  Taking off rn: radar.

Comment 9

[don]

Re-assigned to [e-mail].

Gagan, is this a netlib bug?  Who should get this?

Comment 10

[leger]

Setting all current Open/Normal to M4.

Comment 11

[Paul MacQuiddy]

setting paulmac as QA contact for all gagan's bugs (sorry for the spam)

Comment 12

[Gagan]

Nisheeth can you confirm that this is fixed with your webshell fixes? If not
give it back to me. Thanks!

Comment 13

[Nisheeth Ranjan]

Yes, this is fixed.  Pam's page appears fine.

Comment 14

[Paul MacQuiddy]

Looks good to me also. Marking verified.