1461020 - Decide what the mirror should do about invalid records

Status: RESOLVED DUPLICATE of bug 1482608

(Firefox :: Sync, enhancement, P3)

Description

[Lina Butler [:lina]]

We currently ignore records with invalid GUIDs and URLs before storing them in the mirror, since Places can't handle them. This might cause the local tree to diverge, and introduce validation errors, since the mirror doesn't match what's on the server.

I'm not sure what the right approach here is. For GUIDs, we could generate a new, valid GUID, and upload a tombstone for the invalid one. This could be done with an `UPDATE` on `items`, and an `AFTER UPDATE OF guid ON items` trigger to insert tombstones into `moz_bookmarks_deleted`.

For syntactically invalid URLs (a URL like `about:feedback` might be meaningful on Android, not Desktop, but it's still well-formed, so Places stores it just fine), it's trickier. We could replace the URL with something like `about:blank`, or just delete the item. Since we'll need to reupload the item either way, deleting is easier than fixing.

Comment 1

[Lina Butler [:lina]]

Fixed in https://hg.mozilla.org/mozilla-central/rev/e7282f4449c8.