1461023 - Disable the assertion that checks that we have surely the previous opacity value when we skip computing opacity animation value on the compositor

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

From bug 1176019 comment 43;

> My patch seems to be crashing unwrapping the Maybe on this line: https://searchfox.org/mozilla-central/source/gfx/layers/composite/AsyncCompositionManager.cpp#722. The test seems to fail when switching between tabs very quickly (can't reproduce it locally).

So, I think the case is that we've already dropped the past animation values from animation storage but haven't yet removed animations from the layer.

I am going to disable the assertion here in this bug and re-enable it in bug 1459775 along with the proper fix.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation.

We are going to re-enable the assertion with a proper fix in bug 1461023.

Review commit: https://reviewboard.mozilla.org/r/243538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243538/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8975191 [details]
Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243538/diff/1-2/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8975191 [details]
Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation.

https://reviewboard.mozilla.org/r/243538/#review249410

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0624369b3b08
Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation. r=kats

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0624369b3b08

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e891abf73fe