Closed Bug 1461023 Opened Last year Closed Last year

Disable the assertion that checks that we have surely the previous opacity value when we skip computing opacity animation value on the compositor

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

From bug 1176019 comment 43;

> My patch seems to be crashing unwrapping the Maybe on this line: https://searchfox.org/mozilla-central/source/gfx/layers/composite/AsyncCompositionManager.cpp#722. The test seems to fail when switching between tabs very quickly (can't reproduce it locally).

So, I think the case is that we've already dropped the past animation values from animation storage but haven't yet removed animations from the layer.

I am going to disable the assertion here in this bug and re-enable it in bug 1459775 along with the proper fix.
Comment on attachment 8975191 [details]
Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation.

https://reviewboard.mozilla.org/r/243538/#review249410
Attachment #8975191 - Flags: review?(bugmail) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0624369b3b08
Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation. r=kats
https://hg.mozilla.org/mozilla-central/rev/0624369b3b08
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.