1461048 - Update FluentDOM to 0.3.0

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P1)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Once we land https://github.com/projectfluent/fluent.js/pull/195 we'll release new FluentDOM and want to update in-gecko version to unblock bug 1455649.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1461048 - Update FluentDOM to 0.3.0.

Review commit: https://reviewboard.mozilla.org/r/243838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243838/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0.

Review commit: https://reviewboard.mozilla.org/r/243840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243840/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8975595 [details]
Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0.

https://reviewboard.mozilla.org/r/243840/#review249730

::: intl/l10n/DOMLocalization.jsm:648
(Diff revision 1)
>        // all translations that is needed for DOM Overlay.
>        const overlayTranslations = [];
>  
>        const getTranslationsForItems = async l10nItems => {
> -        const keys = l10nItems.map(l10nItem => [l10nItem.l10nId, l10nItem.l10nArgs]);
> +        const keys = l10nItems.map(l10nItem => {
> +          return {id: l10nItem.l10nId, args: l10nItem.l10nArgs}

If you want to avoid the braces and return statement you can just wrap the object to return in parentheses ()

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

The first is just a deployment of FluentDOM 0.3.0 - the actual changes were reviewed by :stas in https://github.com/projectfluent/fluent.js/commits/master/fluent-dom

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8975594 [details]
Bug 1461048 - Update FluentDOM to 0.3.0.

https://reviewboard.mozilla.org/r/243838/#review249732

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8975595 [details]
Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243840/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80651ee9277b
Update FluentDOM to 0.3.0. r=mossop
https://hg.mozilla.org/integration/autoland/rev/1ba2e60eb70b
Convert Fluent API calls to FluentDOM 0.3.0. r=mossop

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/80651ee9277b
https://hg.mozilla.org/mozilla-central/rev/1ba2e60eb70b