1461154 - Misplaced search box on telemetry.mozilla.org

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Attachment: 2018-05-13_03-34-28.mp4

Debian Testing, KDE, Radeon RX480
Win10 1803, GeForce GTX 1060
2560x1440 (Dell U2515H)

1. Click on the currently selected key (for example GC_MS).
2. Scroll to the top of the list.
3. Scroll the whole website down.
4. The search box shouldn't move.

mozregression --good 2018-05-01 --bad 2018-05-12 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://telemetry.mozilla.org/new-pipeline/evo.html#'
> 12:58.65 INFO: Last good revision: fc4f2d0a1dfb663404260c36c1b5f85fc1b14f96
> 12:58.65 INFO: First bad revision: 84f298282f592fceb8f5f5bb9f3bbfafdf3b7d60
> 12:58.65 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fc4f2d0a1dfb663404260c36c1b5f85fc1b14f96&tochange=84f298282f592fceb8f5f5bb9f3bbfafdf3b7d60

2018-05-11
> 84f298282f59	Kartikaya Gupta — Bug 1459935 - Update for API change in WR PR 2747. r=jrmuizel
> 3ad8053cee91	Kartikaya Gupta — Bug 1459935 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 972eab977ff3	Kartikaya Gupta — Bug 1459935 - Update webrender to commit 4811a6e7c06f9dd1b4056e5f5e66983842983ba0. r=jrmuizel

> WR @ fac0040b4597d6c4a4b36fffbb8117782027e7ca
mozregression --repo try --launch e8c2de382eeefe9e2c7c5178593b4933b0cf49ae --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://telemetry.mozilla.org/new-pipeline/evo.html#'
good

> WR @ 6282697f5b9bc78aedffc41d32fd6745d405e756
mozregression --repo try --launch 36e51f2f4f5ba391535f274c3aabfaa43f9e6bb5 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://telemetry.mozilla.org/new-pipeline/evo.html#'
bad

Regression range: https://github.com/servo/webrender/compare/fac0040b4597d6c4a4b36fffbb8117782027e7ca...6282697f5b9bc78aedffc41d32fd6745d405e756

Comment 1

[Martin Robinson (email:[e-mail])]

I've tracked down the problem and posted a fix here: https://github.com/servo/webrender/pull/2757

Sorry about the regression!

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Thanks for the quick fix!

Comment 3

[Markus Stange [:mstange]]

Since the webrender change didn't include a test, it's probably worth adding a Gecko reftest for this, using reftest-async-scroll.

Comment 4

[Aria Beingessner [:Gankra]]

uhh a bit late to the triage, but since this only needs a test i'm marking this as low priority..?

#still-learning-how-to-do-this

Comment 5

[Gregory Pappas [:gregp]]

Is this still reproducible?

Comment 6

[Darkspirit]

MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --find-fix --bad 2018-05-12 --good 2022-03-08 --pref gfx.webrender.all:true -a https://telemetry.mozilla.org/new-pipeline/evo.html

12:17.60 INFO: First good revision: e1fafe357b36270b835acf86f17aef855ce76fa5 (2018-05-18)
12:17.60 INFO: Last bad revision: 24bae072acb09114c367e6b9ffde9261b2ad8a58 (2018-05-17)
12:17.60 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24bae072acb09114c367e6b9ffde9261b2ad8a58&tochange=e1fafe357b36270b835acf86f17aef855ce76fa5

= "depends on bug 1461342" is correct. This bug just needed to be closed.