1461160 - "AttributeError: 'module' object has no attribute 'sshpeer'" after upgrading Mercurial to 4.6

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I recently upgraded:
 * Mercurial from 3.5.3 to 3.6
 * version-control-tools from 85483f1cae73 to 6dd442f29a57 (current tip)
 * hg-git from c2b555f79f12 to 70c9dfdb0bc1 (current tip)
and I now see the following error in mozext (with hggit stuff also on the stack) when pulling from mozilla-central or comm-central (although I'm not sure if I saw it the first time after the upgrade... I might have just missed the error or maybe it didn't happen).

pulling from https://hg.mozilla.org/mozilla-central/
searching for changes
adding changesets
adding manifests
adding file changes                                                                                
added 251 changesets with 1734 changes to 1026 files                                               
transaction abort!
rollback completed
** Unknown exception encountered with possibly-broken third-party extension qfixdrift
** which supports versions 3.8 of Mercurial.
** Please disable qfixdrift and try your action again.
** If that fixes the bug please report it to the extension author.
** Python 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]
** Mercurial Distributed SCM (version 4.6)
** Extensions loaded: strip, mq, convert, transplant, rebase, extdiff, qfixdrift, graphlog, bzexport, mozext, reviewboard, hggit, histedit, bzpost, qimportbz, push-to-try
Traceback (most recent call last):
  File "/usr/local/bin/hg", line 41, in <module>
    dispatch.run()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 90, in run
    status = (dispatch(req) or 0)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 210, in dispatch
    ret = _runcatch(req)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 351, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 359, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/scmutil.py", line 160, in callcatch
    return func()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 341, in _runcatchfunc
    return _dispatch(req)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 971, in _dispatch
    cmdpats, cmdoptions)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 727, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 979, in _runcommand
    return cmdfunc()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 968, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/hgext/mq.py", line 3599, in mqcommand
    return orig(ui, repo, *args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/hgext/rebase.py", line 1766, in pullrebase
    ret = orig(ui, repo, *args, **opts)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/commands.py", line 4060, in pull
    opargs=pullopargs).cgresult
  File "/home/dbaron/.mozbuild/version-control-tools/hgext/mozext/__init__.py", line 828, in pull
    res = orig(repo, remote, *args, **kwargs)
  File "/home/dbaron/builds/mercurial/hg-git/hggit/util.py", line 60, in inner
    return f(*args, **kwargs)
  File "/home/dbaron/builds/mercurial/hg-git/hggit/__init__.py", line 402, in exchangepull
    return orig(repo, remote, heads, force, bookmarks=bookmarks, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/exchange.py", line 1493, in pull
    _pullobsolete(pullop)
  File "/home/dbaron/.mozbuild/version-control-tools/hgext/mozext/__init__.py", line 438, in exchangepullpushlog
    if isinstance(pullop.remote, sshpeer.sshpeer):
AttributeError: 'module' object has no attribute 'sshpeer'

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that if I disable all extensions except for mozext, I still see the problem, but the error message and stack are a little bit different:

pulling from https://hg.mozilla.org/mozilla-central/
searching for changes
no changes found
** Unknown exception encountered with possibly-broken third-party extension mozext
** which supports versions 4.5 of Mercurial.
** Please disable mozext and try your action again.
** If that fixes the bug please report it to https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer%20Services&component=Mercurial%3A%20mozext
** Python 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]
** Mercurial Distributed SCM (version 4.6)
** Extensions loaded: mozext
Traceback (most recent call last):
  File "/usr/local/bin/hg", line 41, in <module>
    dispatch.run()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 90, in run
    status = (dispatch(req) or 0)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 210, in dispatch
    ret = _runcatch(req)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 351, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 359, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/scmutil.py", line 160, in callcatch
    return func()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 341, in _runcatchfunc
    return _dispatch(req)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 971, in _dispatch
    cmdpats, cmdoptions)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 727, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 979, in _runcommand
    return cmdfunc()
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/dispatch.py", line 968, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/commands.py", line 4060, in pull
    opargs=pullopargs).cgresult
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/extensions.py", line 359, in closure
    return func(*(args + a), **kw)
  File "/home/dbaron/.mozbuild/version-control-tools/hgext/mozext/__init__.py", line 828, in pull
    res = orig(repo, remote, *args, **kwargs)
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/mercurial/exchange.py", line 1493, in pull
    _pullobsolete(pullop)
  File "/home/dbaron/.mozbuild/version-control-tools/hgext/mozext/__init__.py", line 438, in exchangepullpushlog
    if isinstance(pullop.remote, sshpeer.sshpeer):
  File "/usr/local/mercurial-4.6/lib/python2.7/site-packages/hgdemandimport/demandimportpy2.py", line 146, in __getattr__
    return getattr(self._module, attr)
AttributeError: 'module' object has no attribute 'sshpeer'

(If I disable mozext, things work... though I get no pushlog message.)

Comment 2

[Connor Sheehan [:sheehan]]

I think there is an error in the bug report (should read 4.6 as suggested by the path to the Python binary?), but otherwise this looks like a duplicate of Bug 1446457. The stack trace reported here is different though so I'm not going to mark as a dupe for now.

Comment 3

[Phabricator Automation]

Attachment: mozext: make extension compatible with hg4.6 (Bug 1461160) r?gps

All tests under vct/hgext/mozext/tests/ pass with this change.

Comment 4

[Phabricator Automation]

Comment on attachment 8975528 [details]
mozext: make extension compatible with hg4.6 (Bug 1461160) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1275

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/674646171595
mozext: make extension compatible with hg4.6 r=gps

Comment 6

[Phabricator Automation]

Attachment: mozext: mark as compatible with hg46 (Bug 1461160) r?gps

Forgot to add this line to my previous patch

Comment 7

[Phabricator Automation]

Comment on attachment 8975553 [details]
mozext: mark as compatible with hg46 (Bug 1461160) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1278

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3db68698f37c
mozext: mark as compatible with hg46 r=gps

Comment 9

[Kim Moir [:kmoir] ET]

I realize this bug is already fixed, just assigning it to the person who fixed it :-)