Closed Bug 1461243 Opened Last year Closed Last year

Remove some dead Java plugin code

Categories

(Core :: Plug-ins, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(6 files)

No description provided.
Comment on attachment 8975383 [details]
Bug 1461243 - Part 1: Remove unused member variable mHaveJavaC2PJSObjectQuirk.

https://reviewboard.mozilla.org/r/243674/#review249714
Attachment #8975383 - Flags: review?(jmathies) → review+
Comment on attachment 8975384 [details]
Bug 1461243 - Part 2: Remove unused functions NS_CheckIsJavaCompatibleURLString() and NS_MakeRandomInvalidURLString().

https://reviewboard.mozilla.org/r/243676/#review249716
Attachment #8975384 - Flags: review?(jmathies) → review+
Comment on attachment 8975385 [details]
Bug 1461243 - Part 3: Remove unused Java `codebase` check from nptest plugin.

https://reviewboard.mozilla.org/r/243678/#review249718
Attachment #8975385 - Flags: review?(jmathies) → review+
Comment on attachment 8975386 [details]
Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.

https://reviewboard.mozilla.org/r/243680/#review249720

I don't have the permissions to r+ telemetry changes. lgtm but please ask a telemetry peer for an r+ too.
Attachment #8975386 - Flags: review?(jmathies) → review+
Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review249722
Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review249724
Attachment #8975387 - Flags: review?(jmathies) → review+
Comment on attachment 8975388 [details]
Bug 1461243 - Part 6: Stub out obsolete NPAPI APIs _getJavaEnv and _getJavaPeer.

https://reviewboard.mozilla.org/r/243684/#review249726

Thanks for these!
Attachment #8975388 - Flags: review?(jmathies) → review+
(In reply to Jim Mathies [:jimm] from comment #11)
> Comment on attachment 8975386 [details]
> Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.
> 
> I don't have the permissions to r+ telemetry changes. lgtm but please ask a
> telemetry peer for an r+ too.

chutten, does a telemetry peer need to review the removal of obsolete probes? e.g.

https://reviewboard.mozilla.org/r/243680/diff/1#index_header
Flags: needinfo?(chutten)
Good question. It doesn't hurt to ask one of us for a quick once-over, but I wouldn't call it a requirement.
Flags: needinfo?(chutten)
Attachment #8975386 - Flags: review?(chutten)
Comment on attachment 8975386 [details]
Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.

https://reviewboard.mozilla.org/r/243680/#review249930

Pleased as always to see unused stuff go away.
Attachment #8975386 - Flags: review?(chutten) → review+
Attachment #8975387 - Flags: review?(bzbarsky)
Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review250190

::: dom/webidl/Navigator.webidl:189
(Diff revision 1)
>    readonly attribute boolean cookieEnabled;
>    [Throws, Constant, Cached, NeedsCallerType]
>    readonly attribute DOMString buildID;
>  
>    // WebKit/Blink/Trident/Presto support this.
> -  [Throws, NeedsCallerType]
> +  [Pure]

[Constant], not [Pure], right?  ;)
Attachment #8975387 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #18)
> > -  [Throws, NeedsCallerType]
> > +  [Pure]
> 
> [Constant], not [Pure], right?  ;)

navigator.javaEnabled() is a function and:

> WebIDL.WebIDLError: error: Methods must not be flagged as [Constant]
Oh, right.  Then:

  [Affects=Nothing, DependsOn=Nothing]
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0246d14a89
Part 1: Remove unused member variable mHaveJavaC2PJSObjectQuirk. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/82d730995296
Part 2: Remove unused functions NS_CheckIsJavaCompatibleURLString() and NS_MakeRandomInvalidURLString(). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e5dc1e92060
Part 3: Remove unused Java `codebase` check from nptest plugin. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f02f3bb5c6b
Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe. r=jimm r=chutten
https://hg.mozilla.org/integration/mozilla-inbound/rev/0124ef77616c
Part 5: Stub out obsolete DOM API navigator.javaEnabled(). r=jimm r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5f49315fec2
Part 6: Stub out obsolete NPAPI APIs _getJavaEnv and _getJavaPeer. r=jimm
Depends on: 1467452
You need to log in before you can comment on or make changes to this bug.