1461243 - Remove some dead Java plugin code

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 1: Remove unused member variable mHaveJavaC2PJSObjectQuirk.

Review commit: https://reviewboard.mozilla.org/r/243674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243674/

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 2: Remove unused functions NS_CheckIsJavaCompatibleURLString() and NS_MakeRandomInvalidURLString().

These functions were only used in some Java workarounds in NPAPI _getproperty.

Review commit: https://reviewboard.mozilla.org/r/243676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243676/

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 3: Remove unused Java `codebase` check from nptest plugin.

Review commit: https://reviewboard.mozilla.org/r/243678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243678/

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.

Review commit: https://reviewboard.mozilla.org/r/243680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243680/

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

We can't remove navigator.javaEnabled() entirely because that would break any web content that tries to call the function.

Review commit: https://reviewboard.mozilla.org/r/243682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243682/

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: Bug 1461243 - Part 6: Stub out obsolete NPAPI APIs _getJavaEnv and _getJavaPeer.

Review commit: https://reviewboard.mozilla.org/r/243684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243684/

Comment 7

[Chris Peterson [:cpeterson]]

Green Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dea3a56f31941547696a791f397c57982c6e708

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8975383 [details]
Bug 1461243 - Part 1: Remove unused member variable mHaveJavaC2PJSObjectQuirk.

https://reviewboard.mozilla.org/r/243674/#review249714

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8975384 [details]
Bug 1461243 - Part 2: Remove unused functions NS_CheckIsJavaCompatibleURLString() and NS_MakeRandomInvalidURLString().

https://reviewboard.mozilla.org/r/243676/#review249716

Comment 10

[Jim Mathies [:jimm]]

Comment on attachment 8975385 [details]
Bug 1461243 - Part 3: Remove unused Java `codebase` check from nptest plugin.

https://reviewboard.mozilla.org/r/243678/#review249718

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 8975386 [details]
Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.

https://reviewboard.mozilla.org/r/243680/#review249720

I don't have the permissions to r+ telemetry changes. lgtm but please ask a telemetry peer for an r+ too.

Comment 12

[Jim Mathies [:jimm]]

Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review249722

Comment 13

[Jim Mathies [:jimm]]

Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review249724

Comment 14

[Jim Mathies [:jimm]]

Comment on attachment 8975388 [details]
Bug 1461243 - Part 6: Stub out obsolete NPAPI APIs _getJavaEnv and _getJavaPeer.

https://reviewboard.mozilla.org/r/243684/#review249726

Thanks for these!

Comment 15

[Chris Peterson [:cpeterson]]

(In reply to Jim Mathies [:jimm] from comment #11)
> Comment on attachment 8975386 [details]
> Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.
> 
> I don't have the permissions to r+ telemetry changes. lgtm but please ask a
> telemetry peer for an r+ too.

chutten, does a telemetry peer need to review the removal of obsolete probes? e.g.

https://reviewboard.mozilla.org/r/243680/diff/1#index_header

Comment 16

[Chris H-C :chutten]

Good question. It doesn't hurt to ask one of us for a quick once-over, but I wouldn't call it a requirement.

Comment 17

[Chris H-C :chutten]

Comment on attachment 8975386 [details]
Bug 1461243 - Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe.

https://reviewboard.mozilla.org/r/243680/#review249930

Pleased as always to see unused stuff go away.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8975387 [details]
Bug 1461243 - Part 5: Stub out obsolete DOM API navigator.javaEnabled().

https://reviewboard.mozilla.org/r/243682/#review250190

::: dom/webidl/Navigator.webidl:189
(Diff revision 1)
>    readonly attribute boolean cookieEnabled;
>    [Throws, Constant, Cached, NeedsCallerType]
>    readonly attribute DOMString buildID;
>  
>    // WebKit/Blink/Trident/Presto support this.
> -  [Throws, NeedsCallerType]
> +  [Pure]

[Constant], not [Pure], right?  ;)

Comment 19

[Chris Peterson [:cpeterson]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #18)
> > -  [Throws, NeedsCallerType]
> > +  [Pure]
> 
> [Constant], not [Pure], right?  ;)

navigator.javaEnabled() is a function and:

> WebIDL.WebIDLError: error: Methods must not be flagged as [Constant]

Comment 20

[Boris Zbarsky [:bzbarsky]]

Oh, right.  Then:

  [Affects=Nothing, DependsOn=Nothing]

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0246d14a89
Part 1: Remove unused member variable mHaveJavaC2PJSObjectQuirk. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/82d730995296
Part 2: Remove unused functions NS_CheckIsJavaCompatibleURLString() and NS_MakeRandomInvalidURLString(). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e5dc1e92060
Part 3: Remove unused Java `codebase` check from nptest plugin. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f02f3bb5c6b
Part 4: Remove obsolete CHECK_JAVA_ENABLED telemetry probe. r=jimm r=chutten
https://hg.mozilla.org/integration/mozilla-inbound/rev/0124ef77616c
Part 5: Stub out obsolete DOM API navigator.javaEnabled(). r=jimm r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5f49315fec2
Part 6: Stub out obsolete NPAPI APIs _getJavaEnv and _getJavaPeer. r=jimm

Comment 22

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/2d0246d14a89
https://hg.mozilla.org/mozilla-central/rev/82d730995296
https://hg.mozilla.org/mozilla-central/rev/7e5dc1e92060
https://hg.mozilla.org/mozilla-central/rev/5f02f3bb5c6b
https://hg.mozilla.org/mozilla-central/rev/0124ef77616c
https://hg.mozilla.org/mozilla-central/rev/f5f49315fec2