Closed Bug 146125 Opened 22 years ago Closed 22 years ago

Image map inside <TH separated from following image

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: gnome, Assigned: waterson)

References

(
URL
)

Details

(Keywords: compat, testcase, Whiteboard: [adt2 RTM] [FIXED ON TRUNK] [ETA 06/20])

Attachments

(4 files, 1 obsolete file)

How Mozilla incorrectly renders the site
97.62 KB, image/jpeg
Details
How the site should look
82.85 KB, image/jpeg
Details
Corrected test case
276 bytes, text/html
Details
add <th> to cases where we zero top- and bottom-margins
8.04 KB, patch
dbaron
: review+
kinmoz
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4; en-US; rv:1.0rc2) Gecko/20020508
BuildID:    

Image map and image combos contained inside table headers (<TH> .. </TH>) get
split from other combos that should butt up against each other to form a
seamless-looking whole.

Reproducible: Always
Steps to Reproduce:
Just go to the site.

Actual Results:  See MidweekRenderBug.jpg

Expected Results:  Seamless-looking image. See
MidweekWebsiteNS6_61(correct_appearance).jpg

    
    

    
  


  

    
    

    
  
Not OS/2 specific.

I see this on a current Windows build.
Assignee: Matti → attinasi
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
OS: OS/2 → All
QA Contact: imajes-qa → petersen
Hardware: PC → All

    
    

    
  
Changing QA contact to Moied
QA Contact: petersen → moied

    
    

    
  

      
      
      
      

        Attached file
          
        min test case (obsolete)
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached file
          
        Corrected test case
        — 
      

    


  

        Attachment #85334 -
        Attachment is obsolete: true

    
  
Keywords: testcase
Priority: -- → P4

    
    

    
  
This pages `works' in 4.x and IE.

It lays out correctly in Mozilla after adding the following rule to quirks.css:

  th > :first-node { margin: 0; }

We probably just need to duplicate the cases already there for <body> and <td>.
Assignee: attinasi → waterson
Keywords: 4xp, 
          
            compat
Target Milestone: --- → Future

    
  
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.0.1

    
    

    
  


  
This patch looks big, but it's not. It just adds <th> to all the places where
we currently zero the top-margin or bottom-margin.

    
    

    
  
Comment on attachment 85358 [details] [diff] [review]
add <th> to cases where we zero top- and bottom-margins

r=dbaron if you did this using regular expression replacement in your editor. 
If not, I'll do it that way in vi and compare diffs...

        Attachment #85358 -
        Flags: review+

    
    

    
  
I did, indeed. ;-)

    
    

    
  
Comment on attachment 85358 [details] [diff] [review]
add <th> to cases where we zero top- and bottom-margins

sr=kin@netscape.com

        Attachment #85358 -
        Flags: superreview+

    
    

    
  
Fix checked in on the trunk. This is a low-risk fix that improves compatibility
-- nominating for RTM.
Keywords: adt1.0.1+

    
  
Whiteboard: [FIXED ON TRUNK]

    
    

    
  
Resolving as fixed, since this has landed on the trunk. Addin adt1.0.1 and
mozilla1.0.1 to nominate it for the branch.

can someone elaborate on the value of "compatibility" in this case, and the
visibility of this issue to a user. thanks!
Keywords: approval, 
          
            mozilla1.0.1, 
          
            nsbeta1, 
          
            verifyme
Whiteboard: [FIXED ON TRUNK] → [FIXED ON TRUNK] [needs impact]

    
    

    
  
It's a typical compatibility bug: if someone relies on there not being spacing
around an image in a table header, then this will cause the page to layout
incorrectly.

    
    

    
  
Probably not many pages do this, but those that do will look bad.

    
  
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [FIXED ON TRUNK] [needs impact] → [adt2 RTM] [FIXED ON TRUNK] [ETA 06/20]

    
    

    
  
Comment on attachment 85358 [details] [diff] [review]
add <th> to cases where we zero top- and bottom-margins

Approved for 1.0 branch.  Please remove mozilla1.0.1+ when it's fixed and add
fixed1.0.1

        Attachment #85358 -
        Flags: approval+

    
    

    
  
Fix checked in on branch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: mozilla1.0.1+ → fixed1.0.1
Resolution: --- → FIXED

    
    

    
  
Verified fixed with branch build 20020625 on winXP
Status: RESOLVED → VERIFIED

    
  
Keywords: verifyme → verified1.0.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: