1461281 - [Firefox Screenshots] The image disappears in edit mode if you hover a color that is positioned under the image

Status: VERIFIED WORKSFORME

(Core :: Web Painting, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: image disappears.mp4

[Affected versions]:
- Nightly 62.0a1
- Screenshots 32.1.0 dev version

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- The "xpinstall.signatures.required" boolean pref is set to "false".
- The "extensions.legacy.enabled" boolean pref is set tot "true".
- The "extensions.install.requireBuiltInCerts" is set to "false".
- Have the Screenshots 32.1.0dev version installed from here: https://screenshots.stage.mozaws.net/homepage/install-test-local.html.
- Have a saved shot link.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and navigate to the saved shot link.
2. Click the "Edit this image" button.
3. Resize the browser so the image is positioned under any of the colors row.
4. Hover one color from the row and observe the behavior.

[Expected result]:
- The color gets focused.

[Actual result]:
- The image disappears.

[Regression]:
Last good revision: dab18a77fd23c5b2794dd54727ded70f319d89a9
First bad revision: b52b2eb81d1e52d259d55d948281c7f6ddf1270c
Pushlog: https://goo.gl/Eq7SE2

Looks like bug 1453541 introduced this issue.

[Notes]:
- The image reappears if you hover other colors from a different row or if you click the "Color Picker" button.
- This issue is also logged in the Screenshots repository from Github: https://github.com/mozilla-services/screenshots/issues/4438
- The issue is not reproducible with Screnshots production version which is on Nightly by default, because the image is not centred on the page (see bug https://github.com/mozilla-services/screenshots/issues/3994). The issue is fixed on Screenshots dev version and will be also fixed on Screenshots production version after the fix will be deployed.
- Attached a screen recording of the issue.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

@Matt can you please take a look at this issue?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Bug 1453541 is targeting Fx61, so calling this affected to get it on the radar.

Comment 3

[Miko Mynttinen]

I cannot reproduce this on Win10/Mac with staging (31.4.1198) or dev (32.1.3865) versions of Firefox Screenshots. The Nightly versions tried were 2018-5-12 to 2018-5-14.

I believe that the actual addon version does not matter, but rather the website where the screenshots are uploaded. Cosmin, can you still reproduce this? If so, could you please try to save the webpage locally and share it?

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

@Miko, indeed the issue is no longer reproducible. I have retested this with the latest Nightly (2018-05-16) build and also with the older Nightly builds from 2018-05-12 and 2018-05-13 using the latest version of Screenshots dev on Windows 7 x64, 10 x64 and Mac 10.13.

The Annotations code has been refactorized, so probably the issue was fixed on the Screenshots side by: https://github.com/mozilla-services/screenshots/issues/4389. 
Considering this I will close the issue as Resolved - WFM.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

It's mildly concerning to me that we appear to have possibly worked around a platform regression by refactoring the frontend code which happened to be hitting it.