1461311 - Undo reftest changes made in bug 1437036

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1437036, to implement WebRenderLayerManager::GetLastTransactionId, we had to make a few reftest changes to work around assumptions in the reftest that are not satisfied by WebRender. We also had to disable a reftest on Android, which is not ideal. This bug is tracking the cleanup.

bug 779598 for example might be one way to do this more robustly. Another might be to have WebRender not continuously do repaints for animations that are not visibly changing; this happens at [1]. Both of these are described by hiro at https://bugzilla.mozilla.org/show_bug.cgi?id=1437036#c37

[1] https://searchfox.org/mozilla-central/rev/a85db9e29eb3f022dbaf8b9a6390ecbacf51e7dd/layout/painting/nsDisplayList.cpp#642

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Backing out the reftest changes still results in a green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6769522cd873c665475f01527c5401d668050413

So we should do that, as it looks like the reftest changes have caused an increase in intermittent failures on non-QR platform in these tests.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more.

Review commit: https://reviewboard.mozilla.org/r/249946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249946/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8984114 [details]
Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more.

https://reviewboard.mozilla.org/r/249946/#review256386

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1213f470f4
Undo reftest/harness changes from bug 1437036 as they are not needed any more. r=hiro

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8b1213f470f4