Closed Bug 1461311 Opened 4 years ago Closed 4 years ago

Undo reftest changes made in bug 1437036

Categories

(Core :: Graphics: WebRender, enhancement, P2)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1437036, to implement WebRenderLayerManager::GetLastTransactionId, we had to make a few reftest changes to work around assumptions in the reftest that are not satisfied by WebRender. We also had to disable a reftest on Android, which is not ideal. This bug is tracking the cleanup.

bug 779598 for example might be one way to do this more robustly. Another might be to have WebRender not continuously do repaints for animations that are not visibly changing; this happens at [1]. Both of these are described by hiro at https://bugzilla.mozilla.org/show_bug.cgi?id=1437036#c37

[1] https://searchfox.org/mozilla-central/rev/a85db9e29eb3f022dbaf8b9a6390ecbacf51e7dd/layout/painting/nsDisplayList.cpp#642
Priority: -- → P2
No longer depends on: 1461239
Backing out the reftest changes still results in a green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6769522cd873c665475f01527c5401d668050413

So we should do that, as it looks like the reftest changes have caused an increase in intermittent failures on non-QR platform in these tests.
Assignee: nobody → bugmail
Blocks: 1461527
No longer blocks: 1407090
Comment on attachment 8984114 [details]
Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more.

https://reviewboard.mozilla.org/r/249946/#review256386
Attachment #8984114 - Flags: review?(hikezoe) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b1213f470f4
Undo reftest/harness changes from bug 1437036 as they are not needed any more. r=hiro
https://hg.mozilla.org/mozilla-central/rev/8b1213f470f4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.