1461488 - Trim tup's display for generated files with many output files

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1461488 - trim tup's display of commands with many outputs;

Some commands produce a large number of output files, such as
make-system-wrappers.py, which has over 1000 outputs. The GeneratedFile
handler in the tup backend displayed all the outputs, which makes the
build output unreadable, and breaks 'tup graph'. This patch displays
only the first 3 outputs and truncates the rest.

Review commit: https://reviewboard.mozilla.org/r/243892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243892/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8975645 [details]
Bug 1461488 - trim tup's display of commands with many outputs;

https://reviewboard.mozilla.org/r/243892/#review249798

::: python/mozbuild/mozbuild/backend/tup.py:656
(Diff revision 1)
> +            display_outputs = ', '.join(outputs[0:3])
> +            if len(outputs) > 3:
> +                display_outputs += ', ...'

Wow, I never realized the slice notation doesn't throw an `IndexError` for slices out of bounds. Would this be a little clearer with just `display_outputs = ', '.join(outputs)` in an else block?

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8975645 [details]
Bug 1461488 - trim tup's display of commands with many outputs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243892/diff/1-2/

Comment 4

[Michael Shal [:mshal]]

(In reply to Chris Manchester (:chmanchester) from comment #2)
> ::: python/mozbuild/mozbuild/backend/tup.py:656
> (Diff revision 1)
> > +            display_outputs = ', '.join(outputs[0:3])
> > +            if len(outputs) > 3:
> > +                display_outputs += ', ...'
> 
> Wow, I never realized the slice notation doesn't throw an `IndexError` for
> slices out of bounds. Would this be a little clearer with just
> `display_outputs = ', '.join(outputs)` in an else block?

Good idea - fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3bdac11bc8
trim tup's display of commands with many outputs; r=chmanchester

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cf3bdac11bc8