1461509 - Firefox allowing a read only date/time input field to be erased

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Eduardo Reyes]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180503143129

Steps to reproduce:

Add the following input element on a form:

<input type="date" name="AppDate" id="appdate" readonly required>




Actual results:

Firefox does not allow to type in the field but allows the content to be deleted. It also ignores the required attribute


Expected results:

I initialized the date field to the current date and was expecting the date would remain unchaged

Comment 1

[Gingerbread Man]

(In reply to Eduardo Reyes from comment #0)
> <input type="date" name="AppDate" id="appdate" readonly required>

Is there more to it? That just shows a "mm / dd / yyyy" placeholder that can be selected but not erased with either Backspace or Delete.

Comment 2

[Eduardo Reyes]

I use the following function to pre-populate the field:

function SetAppDate() {
  var d = new Date();
  d = d.toISOString();
  document.getElementById("appdate").value = d.substr(0,10);
}

But the user can click in the date field and delete its content using Backspace. Even more, this is a form field and when the form is submitted, the posted value is null defeating both the readonly and require clauses

Comment 3

[Gingerbread Man]

Attachment: testcase 1

I'm putting this back in Core :: Layout: Form Controls. Please don't place bugs in General unless you're fairly certain no other component is more suitable.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=001d49708a355c9b127fc338722959874cfc7552&tochange=7abafd0fead900aec67b0de342f71ec856f561cf

The issue is reproducible with the attached testcase. Additionally,
* There's also a (x) button on the right side of the field to clear it, which does nothing when clicked. That should probably not be there at all.
* Prior to the regression, the date format matches my system settings. Afterwards, it's MM / DD / YYYY. That's bug 1421910.

Comment 4

[Eduardo Reyes]

Oh, sorry! I am not familiar with your classification so did not know where to place it

Comment 5

[Eduardo Reyes]

Please don't forget that despite this entry field being marked as required it still goes through when the form is submitted. Is that the expected behavior?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Yep, this is a legitimate bug in the implementation.

Hey dholbert, out of curiosity, do you know who under Layout tends to take care of form controls these days? Or is this something that DOM folk tends to take care of?

Comment 7

[Daniel Holbert [:dholbert]]

jwatt is one layouty person who's done some recent-ish work in form-control-land.

Having said that, I'd bet the "readonly" invariant is enforced somewhere in DOM code, not in layout code.  (And the "Layout:Form Controls" component is about the rendering/sizing, not about code involved with interaction / field-editing so much.) So this probably belongs in a DOM component --> moving.

I have no idea how "readonly" is enforced in other form controls, but we probably need to copy some checks to the datetime implementation from other form controls.

Comment 8

[(no longer active)]

FWIW I don't think calling this a regression is exactly right since bug 1366188 just enabled datetime controls...  But we should try to fix this sooner than later now that we have enabled these controls.  -> P2.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Pretty sure we need to just check readonly/disabled states in https://searchfox.org/mozilla-central/rev/bf4def01bf8f6ff0d18f02f2d7e9efc73e12c63f/toolkit/content/widgets/datetimebox.xml#1790

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1461509 - Don't allow clearing fields in date / time inputs when using backspace if disabled or readonly. r=smaug

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ffcac1a672
Don't allow clearing fields in date / time inputs when using backspace if disabled or readonly. r=smaug

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/77ffcac1a672