Closed
Bug 1461555
Opened 6 years ago
Closed 6 years ago
Rename PseudoStack to ProfilingStack
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(2 files)
The name "PseudoStack" isn't very descriptive. In https://github.com/devtools-html/perf.html/issues/836#issuecomment-371280239 , Greg proposed we rename it to ProfilingStack, and I concur. The header file that it's defined in is already called ProfilingStack.h. PseudoStack -> ProfilingStack ProfileEntry -> ProfilingStackFrame
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8975729 [details] Bug 1461555 - Rename ProfileEntry to ProfilingStackFrame. https://reviewboard.mozilla.org/r/243960/#review250158
Attachment #8975729 -
Flags: review?(n.nethercote) → review+
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8975730 [details] Bug 1461555 - Rename PseudoStack to ProfilingStack. https://reviewboard.mozilla.org/r/243962/#review250160
Attachment #8975730 -
Flags: review?(n.nethercote) → review+
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/d3ca79e708a5 Rename ProfileEntry to ProfilingStackFrame. r=njn https://hg.mozilla.org/integration/autoland/rev/589325c8b1a3 Rename PseudoStack to ProfilingStack. r=njn
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d3ca79e708a5 https://hg.mozilla.org/mozilla-central/rev/589325c8b1a3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•