1461685 - The bookmarks toolbar is displayed empty after creating a separator before its first bookmark

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 62.0a1 (2018-05-14)
- 61.0b5 (20180514150347)
- 60.0 build2 (20180503143129)

[Affected platforms]:
- Mac OS X 10.10.5
- Windows 10 x64
- Ubuntu 16.04 x86

[Steps to reproduce]:
1. Launch Firefox
2. Enable the bookmarks toolbar 
3. Create a separator before the first bookmark/folder from the toolbar 
4. Disable the bookmarks toolbar 
5. Enable back the bookmarks toolbar

[Expected result]:
- All its items are properly displayed

[Actual result]:
- The bookmarks toolbar is displayed as being empty 

[Regression range]:
- Last good revision: acf2ccf34d753305b27487c55ca80ad37b61136a
- First bad revision: a0be5817a7214701ba799edef2dcda16d29195fc
- Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=acf2ccf34d753305b27487c55ca80ad37b61136a&tochange=a0be5817a7214701ba799edef2dcda16d29195fc
- it seems that bug 1392081 regressed this problem

[Additional notes]:
- the issue is reproducible till deleting/moving the separator from that particular position

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1461685 - The bookmarks toolbar is empty if the first bookmark is a separator.

Review commit: https://reviewboard.mozilla.org/r/244616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244616/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8976493 [details]
Bug 1461685 - The bookmarks toolbar is empty if the first bookmark is a separator.

https://reviewboard.mozilla.org/r/244616/#review251422

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0dc0094001b
The bookmarks toolbar is empty if the first bookmark is a separator. r=standard8

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b0dc0094001b