1461728 - update scriptworkers to latest deps

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Comment 1

[Aki Sasaki (not active)]

Attachment: pushapk.diff

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8975865 [details] [diff] [review]
pushapk.diff

Review of attachment 8975865 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

We still don't have integration tests, despite [1]. Please land it. I'll be ready to back this patch out if I see tomorrow's nightly busted. 

[1] https://github.com/mozilla-releng/pushapkscript/issues/34

::: modules/pushapk_scriptworker/files/requirements.txt
@@ +34,2 @@
>  lxml==4.2.1
> +matplotlib==2.2.2

Note to self: These new reqs are because of https://github.com/androguard/androguard/blob/v3.2.0/setup.py#L25

@@ -37,4 @@
>  pickleshare==0.7.4
>  prompt_toolkit==1.0.15
>  ptyprocess==0.5.2
> -pushapkscript==0.6.0

We probably still need this dependency :)

Comment 3

[Johan Lorenzo [:jlorenzo]]

I should have said, r+ with nit on pushapkscript.

Comment 4

[Aki Sasaki (not active)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #2)
> @@ -37,4 @@
> >  pickleshare==0.7.4
> >  prompt_toolkit==1.0.15
> >  ptyprocess==0.5.2
> > -pushapkscript==0.6.0
> 
> We probably still need this dependency :)

Haha, good catch :)
Added to the end. I should be careful about this for other patches going forward.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/9fb1293a1aa9
update pushapk to latest deps. r=jlorenzo

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/8a5feeb21bf3
typo fix. r=bustage

Comment 7

[Aki Sasaki (not active)]

Attachment: pushsnap.diff

Comment 8

[Aki Sasaki (not active)]

Attachment: shipit.diff

Comment 9

[Aki Sasaki (not active)]

Attachment: transparency.diff

Comment 10

[Aki Sasaki (not active)]

Leaning towards leaving bbb2 until esr52 is EOLed in early September.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/c6d14b8861ee
bump transparencyscript deps. r=nthomas

Comment 12

[Phabricator Automation]

Attachment: Bug 1461728 - update addonscript to latest deps (and bump to 1.0). r=aki

update scriptworkers to latest deps

Comment 13

[Phabricator Automation]

Comment on attachment 8976021 [details]
Bug 1461728 - update addonscript to latest deps (and bump to 1.0). r=aki

Aki Sasaki [:aki] has approved the revision.

https://phabricator.services.mozilla.com/D1293

Comment 14

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8975890 [details] [diff] [review]
pushsnap.diff

Review of attachment 8975890 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/pushsnap_scriptworker/files/requirements.txt
@@ -32,3 @@
>  pyxdg==0.26
> -PyYAML==3.12
> -redo==1.6

I see this req disappeared. If I remember correctly, this is a scriptworker dep. I don't see it listed on the req list[1]. I'm sure it's not needed by pushsnapscript[2]. I'm okay to remove it, but I don't know what's the cost.

[1] https://github.com/mozilla-releng/scriptworker/blob/fd42dde1bdd7e6718e3d1b09dc561cf5e2e71f5c/requirements-prod.txt#L1
[2] https://github.com/mozilla-releng/pushsnapscript/blob/aab7ccf6d7476ebd719a7ffcd1179f4ad41b53c6/requirements.txt#L1

Comment 15

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8975913 [details] [diff] [review]
shipit.diff

Review of attachment 8975913 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/shipit_scriptworker/files/requirements.txt
@@ -19,1 @@
>  redo==1.6

Note to self: redo is a dependency of shipitapi[1]

[1] https://github.com/mozilla-releng/shipitapi/blob/2f6afef0d4694fce36dd3e0c7abc127a020676f0/setup.py#L17

Comment 16

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8975865 [details] [diff] [review]
pushapk.diff

Successfully landed and tested at https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=dedd25bfd2794eaba95225361f82c701e49c9339&filter-searchStr=push-apk&selectedJob=178739899

Comment 17

[Aki Sasaki (not active)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #14)
> Comment on attachment 8975890 [details] [diff] [review]
> pushsnap.diff
> 
> Review of attachment 8975890 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/pushsnap_scriptworker/files/requirements.txt
> @@ -32,3 @@
> >  pyxdg==0.26
> > -PyYAML==3.12
> > -redo==1.6
> 
> I see this req disappeared. If I remember correctly, this is a scriptworker
> dep. I don't see it listed on the req list[1]. I'm sure it's not needed by
> pushsnapscript[2]. I'm okay to remove it, but I don't know what's the cost.
> 
> [1]
> https://github.com/mozilla-releng/scriptworker/blob/
> fd42dde1bdd7e6718e3d1b09dc561cf5e2e71f5c/requirements-prod.txt#L1
> [2]
> https://github.com/mozilla-releng/pushsnapscript/blob/
> aab7ccf6d7476ebd719a7ffcd1179f4ad41b53c6/requirements.txt#L1

If we need to keep redo, we need to make sure it shows up in the deps in pushsnapscript's requirements.txt somehow.
`redo` is not in scriptworker's expanded dep list.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/823263df1926
update pushsnapscript deps. r=jlorenzo
https://hg.mozilla.org/build/puppet/rev/3432603ce4b0
shipitscript dep bump. r=jlorenzo

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/7c86459b3ce8
update addonscript to latest deps (and bump to 1.0). r=aki