1461737 - Move nsstring-rs to a better location

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P5)

Description

[Manish Goregaokar [:manishearth]]

nsstring-rs currently lives within servo/ since it was used by both Servo and Gecko and there was syncing.

Servo no longer syncs with Gecko, and no longer needs nsstring-rs, so it should be moved to a more logical location (perhaps next to xpcom-rs).

Comment 1

[Nika Layzell [:nika] (ni? for response)]

I figure this would be a pretty easy good-first-bug for someone?

Comment 2

[Sahil Bhosale]

The file nsstring -rs is at location mozilla-central/servo/support/gecko/nsstring/src/lib.rs and it should be moved to mozilla-central/xpcom/rust/xpcom/src folder. 

It this correct??

Comment 3

[Devika Sugathan]

Hello, can I work on this bug?

Comment 4

[Nika Layzell [:nika] (ni? for response)]

(In reply to Sahil Bhosale from comment #2)
> The file nsstring -rs is at location
> mozilla-central/servo/support/gecko/nsstring/src/lib.rs and it should be
> moved to mozilla-central/xpcom/rust/xpcom/src folder. 
> 
> It this correct??

Sorry for the delay in replying, I've been on PTO :-)

The entire mozilla-central/servo/support/gecko/nsstring directory should be moved to mozilla-central/xpcom/rust/nsstring wholesale, and paths in various files (e.g. Cargo.toml) updated to reflect those changes.

Comment 5

[bitnotri]

Attachment: Bug 1461737 - Move nsstring-rs to a better location, r=nika

Comment 6

[bitnotri]

Hello, 

I've decided to take this on as my first challenge and submitted the patch up for review. Built my first mach build, made the required changes and successfully built the second time. Looking forward to feedback :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e900ef58b0f
Move nsstring-rs to a better location, r=nika

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8e900ef58b0f