Closed Bug 1461737 Opened 2 years ago Closed 11 months ago

Move nsstring-rs to a better location

Categories

(Core :: XPCOM, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: manishearth, Assigned: bitnotri, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

nsstring-rs currently lives within servo/ since it was used by both Servo and Gecko and there was syncing.

Servo no longer syncs with Gecko, and no longer needs nsstring-rs, so it should be moved to a more logical location (perhaps next to xpcom-rs).
I figure this would be a pretty easy good-first-bug for someone?
Assignee: nika → nobody
Mentor: nika
Keywords: good-first-bug
The file nsstring -rs is at location mozilla-central/servo/support/gecko/nsstring/src/lib.rs and it should be moved to mozilla-central/xpcom/rust/xpcom/src folder. 

It this correct??
Flags: needinfo?(nika)
Hello, can I work on this bug?
(In reply to Sahil Bhosale from comment #2)
> The file nsstring -rs is at location
> mozilla-central/servo/support/gecko/nsstring/src/lib.rs and it should be
> moved to mozilla-central/xpcom/rust/xpcom/src folder. 
> 
> It this correct??

Sorry for the delay in replying, I've been on PTO :-)

The entire mozilla-central/servo/support/gecko/nsstring directory should be moved to mozilla-central/xpcom/rust/nsstring wholesale, and paths in various files (e.g. Cargo.toml) updated to reflect those changes.
Flags: needinfo?(nika)
Hello, 

I've decided to take this on as my first challenge and submitted the patch up for review. Built my first mach build, made the required changes and successfully built the second time. Looking forward to feedback :)
Flags: needinfo?(nika)
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e900ef58b0f
Move nsstring-rs to a better location, r=nika
Flags: needinfo?(nika)
https://hg.mozilla.org/mozilla-central/rev/8e900ef58b0f
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.