Closed
Bug 1461803
Opened 7 years ago
Closed 7 years ago
misc. cleanup in psm
Categories
(Core :: Security: PSM, enhancement, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
https://searchfox.org/mozilla-central/search?q=displayUnknownCertErrorAlert&redirect=false shows only the declaration of displayUnknownCertErrorAlert, but no implementation or uses. It can be removed, presumably.
|
Assignee | |
Comment 1•7 years ago
|
||
nsNSSErrors can also be (re)moved to NSSErrorsService (nothing else uses it).
Summary: displayUnknownCertErrorAlert in nsNSSIOLayer.h appears to be unimplemented and unused → misc. cleanup in psm
|
|
Assignee | |
Comment 2•7 years ago
|
||
Some nsICertOverrideService things can be removed as well.
Assignee: nobody → dkeeler
Priority: -- → P1
Whiteboard: [psm-assigned]
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8983236 [details]
bug 1461803 - minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService
https://reviewboard.mozilla.org/r/249108/#review255614
LGTM!
Attachment #8983236 -
Flags: review?(jjones) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Thanks for the review!
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bf5baa08e70b2c25caa5bac06f2bdf97b7af06b (the bc1 failure appears to be intermittent, but there isn't a bug for it that I could find)
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e942111bb149
minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService r=jcj
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•