Closed Bug 1461803 Opened 2 years ago Closed 2 years ago
. cleanup in psm
59 bytes, text/x-review-board-request
https://searchfox.org/mozilla-central/search?q=displayUnknownCertErrorAlert&redirect=false shows only the declaration of displayUnknownCertErrorAlert, but no implementation or uses. It can be removed, presumably.
nsNSSErrors can also be (re)moved to NSSErrorsService (nothing else uses it).
Summary: displayUnknownCertErrorAlert in nsNSSIOLayer.h appears to be unimplemented and unused → misc. cleanup in psm
Some nsICertOverrideService things can be removed as well.
Assignee: nobody → dkeeler
Priority: -- → P1
Comment on attachment 8983236 [details] bug 1461803 - minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService https://reviewboard.mozilla.org/r/249108/#review255614 LGTM!
Attachment #8983236 - Flags: review?(jjones) → review+
Thanks for the review! Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bf5baa08e70b2c25caa5bac06f2bdf97b7af06b (the bc1 failure appears to be intermittent, but there isn't a bug for it that I could find)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e942111bb149 minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService r=jcj
You need to log in before you can comment on or make changes to this bug.