1461803 - misc. cleanup in psm

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

https://searchfox.org/mozilla-central/search?q=displayUnknownCertErrorAlert&redirect=false shows only the declaration of displayUnknownCertErrorAlert, but no implementation or uses. It can be removed, presumably.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

nsNSSErrors can also be (re)moved to NSSErrorsService (nothing else uses it).

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Some nsICertOverrideService things can be removed as well.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1461803 - minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService

Also removes displayUnknownCertErrorAlert, which was declared but never used.
Also removes some unnecessary ns(I)CertOverrideService OID stuff.

Review commit: https://reviewboard.mozilla.org/r/249108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249108/

Comment 4

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8983236 [details]
bug 1461803 - minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService

https://reviewboard.mozilla.org/r/249108/#review255614

LGTM!

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks for the review!
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bf5baa08e70b2c25caa5bac06f2bdf97b7af06b (the bc1 failure appears to be intermittent, but there isn't a bug for it that I could find)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e942111bb149
minor cleanup in PSM: (re)move nsNSSErrors to NSSErrorsService r=jcj

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e942111bb149